Paths

Table of Contentst

Differential D18629

Fix an error in Diffusion when the Owners application is uninstalled
ClosedPublic
Actions

Authored by epriestley on Sep 19 2017, 4:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 18, 8:39 AM

	Unknown Object (File)
	Thu, Feb 13, 2:57 AM

	Unknown Object (File)
	Sun, Feb 9, 4:44 AM

	Unknown Object (File)
	Fri, Feb 7, 3:29 AM

	Unknown Object (File)
	Mon, Feb 3, 1:24 AM

	Unknown Object (File)
	Sun, Feb 2, 9:23 PM

	Unknown Object (File)
	Sat, Feb 1, 7:49 AM

	Unknown Object (File)
	Sun, Jan 26, 10:57 PM

Subscribers

None

Details

Reviewers

Commits

rP52fff638ca9b: (stable) Fix an error in Diffusion when the Owners application is uninstalled
rP03e5d69817c9: Fix an error in Diffusion when the Owners application is uninstalled

Summary

See https://discourse.phabricator-community.org/t/undefined-view-when-owners-is-uninstalled/451.

When Owners is not installed, Diffusion can fatal with a bad $view.

Test Plan

Uninstall Owners.
View the content of any file in Diffusion.
Before: fatal on $view undefined.
After: Valid page with no owners information.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 19 2017, 4:23 PM

Harbormaster completed remote builds in B18500: Diff 44724.Sep 19 2017, 4:24 PM

amckinley accepted this revision.Sep 19 2017, 4:40 PM

This revision is now accepted and ready to land.Sep 19 2017, 4:40 PM

Closed by commit rP03e5d69817c9: Fix an error in Diffusion when the Owners application is uninstalled (authored by epriestley). · Explain WhySep 19 2017, 4:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

120 lines

Diff 44725

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...