Page MenuHomePhabricator
Differential D18629

Fix an error in Diffusion when the Owners application is uninstalled
ClosedPublic
Actions

Authored by epriestley on Sep 19 2017, 4:23 PM.
Tags
None
Referenced Files
F18353080: D18629.id.diff
Wed, Aug 27, 12:36 AM
F18255821: D18629.diff
Thu, Aug 21, 11:44 PM
F17666258: D18629.diff
Jul 12 2025, 8:45 PM
Unknown Object (File)
Apr 29 2025, 2:39 PM
Unknown Object (File)
Apr 25 2025, 4:06 PM
Unknown Object (File)
Apr 13 2025, 11:56 PM
Unknown Object (File)
Apr 12 2025, 11:38 PM
Unknown Object (File)
Apr 10 2025, 11:20 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP52fff638ca9b: (stable) Fix an error in Diffusion when the Owners application is uninstalled
rP03e5d69817c9: Fix an error in Diffusion when the Owners application is uninstalled
Summary

See https://discourse.phabricator-community.org/t/undefined-view-when-owners-is-uninstalled/451.

When Owners is not installed, Diffusion can fatal with a bad $view.

Test Plan
  • Uninstall Owners.
  • View the content of any file in Diffusion.
  • Before: fatal on $view undefined.
  • After: Valid page with no owners information.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
120 lines

Diff 44725

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility