Page MenuHomePhabricator
Differential D18629

Fix an error in Diffusion when the Owners application is uninstalled
ClosedPublic
Actions

Authored by epriestley on Sep 19 2017, 4:23 PM.
Tags
None
Referenced Files
F15406624: D18629.id44724.diff
Tue, Mar 18, 12:56 PM
F15398779: D18629.id44725.diff
Mon, Mar 17, 1:37 AM
F15369354: D18629.diff
Wed, Mar 12, 6:22 AM
F15302820: D18629.diff
Mar 5 2025, 10:24 PM
Unknown Object (File)
Feb 26 2025, 8:23 AM
Unknown Object (File)
Feb 26 2025, 8:22 AM
Unknown Object (File)
Feb 26 2025, 8:04 AM
Unknown Object (File)
Feb 26 2025, 8:00 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP52fff638ca9b: (stable) Fix an error in Diffusion when the Owners application is uninstalled
rP03e5d69817c9: Fix an error in Diffusion when the Owners application is uninstalled
Summary

See https://discourse.phabricator-community.org/t/undefined-view-when-owners-is-uninstalled/451.

When Owners is not installed, Diffusion can fatal with a bad $view.

Test Plan
  • Uninstall Owners.
  • View the content of any file in Diffusion.
  • Before: fatal on $view undefined.
  • After: Valid page with no owners information.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
120 lines

Diff 44725

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility