Page MenuHomePhabricator

Prepare revision mail for the "Draft" status
ClosedPublic

Authored by epriestley on Sep 18 2017, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 17 2024, 6:48 AM
Unknown Object (File)
Feb 11 2024, 2:29 AM
Unknown Object (File)
Feb 2 2024, 3:44 AM
Unknown Object (File)
Feb 1 2024, 11:15 PM
Unknown Object (File)
Jan 16 2024, 4:02 PM
Unknown Object (File)
Jan 6 2024, 6:37 AM
Unknown Object (File)
Dec 27 2023, 12:10 PM
Unknown Object (File)
Dec 27 2023, 12:10 PM
Subscribers
None

Details

Summary

Ref T2543. Currently, we always do some special things when a revision is created, mostly adding more stuff to the mail.

With drafts, we want to suppress initial mail and send this big, rich mail only when the revision actually moves out of "draft".

Prepare the code for this, with the actual methods hard-coded to the current behavior. This will probably take some tweaking but I think I got most of it.

Test Plan

Banged around in Differential so it sent some mail, saw normal mail without anything new.

Diff Detail

Repository
rP Phabricator
Branch
draft3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18497
Build 24909: Run Core Tests
Build 24908: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 18 2017, 11:52 PM
This revision was automatically updated to reflect the committed changes.