Swap "-R" and "serve" argument order for Mercurial
ClosedPublic
Actions

Authored by epriestley on Sep 15 2017, 7:18 PM.

Details

Reviewers

Commits

rP76cdaa4f2d10: (stable) Swap "-R" and "serve" argument order for Mercurial
rPb352cacdd917: Swap "-R" and "serve" argument order for Mercurial

Summary

See https://discourse.phabricator-community.org/t/unable-to-use-current-mercurial-on-debian-stretch/391/13. I missed that -R is order-sensitive.

Test Plan

Verified both orders work on 3.5.2.

Diff Detail

Repository

rP Phabricator

Branch

serve2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18478
Build 24882: Run Core Tests
Build 24881: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 15 2017, 7:18 PM

Harbormaster completed remote builds in B18478: Diff 44701.Sep 15 2017, 7:20 PM

amckinley accepted this revision.Sep 15 2017, 7:42 PM

This revision is now accepted and ready to land.Sep 15 2017, 7:42 PM

Closed by commit rPb352cacdd917: Swap "-R" and "serve" argument order for Mercurial (authored by epriestley). · Explain WhySep 15 2017, 8:07 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13012: Mercurial "--config" and "--debugger" command injection vulnerability.Nov 10 2017, 3:42 PM

epriestley mentioned this in T12521: "(Exception) Expected nonempty 'cmds' specification!" when trying to clone or pull mercurial repository.Jan 4 2018, 7:11 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionServeController.php

2 lines

Diff 44701

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Swap "-R" and "serve" argument order for MercurialClosedPublicActions