Page MenuHomePhabricator

When selecting Ferret ngrams, select term ngrams (not raw ngrams) for term search
ClosedPublic

Authored by epriestley on Sep 8 2017, 4:13 PM.
Tags
None
Referenced Files
F18380957: D18581.diff
Thu, Aug 28, 6:38 PM
F18092471: D18581.id44618.diff
Thu, Aug 7, 10:43 AM
F18087090: D18581.id44621.diff
Wed, Aug 6, 2:18 AM
F17947531: D18581.id.diff
Thu, Jul 31, 5:11 PM
F17932652: D18581.diff
Wed, Jul 30, 8:31 PM
F17930296: D18581.diff
Jul 30 2025, 5:53 PM
Unknown Object (File)
Jun 29 2025, 5:25 PM
Unknown Object (File)
Jun 1 2025, 8:10 AM
Subscribers
None

Details

Summary

Ref T12819. For queries like v0.2, we would incorrectly search for ngrams including 0.2, but this is only a substring ngram: the term corpus splits this into v0 and 2, so 0.2 is not in the ngrams table.

When executing term queries, search for term ngrams instead. This makes "v0.2" work properly again.

Test Plan

Searched for "v0.2", found a task with "v0.2" in the title.

Diff Detail

Repository
rP Phabricator
Branch
ferret32
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18399
Build 24774: Run Core Tests
Build 24773: arc lint + arc unit