Page MenuHomePhabricator

Fix an issue with selecting the right stemmed ngrams with Ferret engine queries
ClosedPublic

Authored by epriestley on Sep 12 2017, 2:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 30, 10:14 PM
Unknown Object (File)
Wed, Jun 15, 10:29 PM
Unknown Object (File)
Wed, Jun 15, 9:21 PM
Unknown Object (File)
Mon, Jun 6, 3:33 PM
Unknown Object (File)
Sat, Jun 4, 10:52 AM
Unknown Object (File)
Jun 2 2022, 10:08 AM
Unknown Object (File)
May 30 2022, 11:48 AM
Subscribers
None

Details

Summary

Ref T12819. In D18581, I corrected one bug (ngram selection for terms) but introduced a minor new bug. We now pass ' query ' (term corpus with boundary spaces) to the stemmer, but it bails out on this since English words don't start with spaces.

Trim these extra boundary spaces off before invoking the stemmer.

The practical effect of this is that searching for non-stem variations of a word ("detection") now finds stemmed variations again ("detect"). Prior to fixing this bug, the stem could find longer variations but not the other way around.

Test Plan

Searched for "detection", found results matching "detect" after patch (and saw same results for "detect" and "detection").

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable