Use selected button state on blame button
ClosedPublic
Actions

Authored by chad on Aug 30 2017, 5:24 PM.

Tags

None

Referenced Files

	F13158793: D18504.diff
	Sun, May 5, 9:43 PM

	Unknown Object (File)
	Thu, Apr 25, 2:54 AM

	Unknown Object (File)
	Fri, Apr 19, 10:20 PM

	Unknown Object (File)
	Fri, Apr 19, 11:50 AM

	Unknown Object (File)
	Thu, Apr 18, 1:03 PM

	Unknown Object (File)
	Wed, Apr 17, 11:50 AM

	Unknown Object (File)
	Thu, Apr 11, 10:24 AM

	Unknown Object (File)
	Thu, Apr 11, 4:02 AM

View All 65 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP67c658a7ed87: Use selected button state on blame button

Summary

Visually selects the button if blame is on.

Test Plan

Turn blame on and off in Diffusion on a file.

Diff Detail

Repository

rP Phabricator

Branch

blame-button (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18223
Build 24508: Run Core Tests
Build 24507: arc lint + arc unit

Event Timeline

chad created this revision.Aug 30 2017, 5:24 PM

Harbormaster completed remote builds in B18223: Diff 44438.Aug 30 2017, 5:24 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 30 2017, 5:24 PM

Harbormaster completed remote builds in B18223: Diff 44438.Aug 30 2017, 5:25 PM

epriestley accepted this revision.Aug 30 2017, 5:45 PM

This revision is now accepted and ready to land.Aug 30 2017, 5:45 PM

Closed by commit rP67c658a7ed87: Use selected button state on blame button (authored by Chad Little <chad@phacility.com>, committed by chad). · Explain WhyAug 30 2017, 6:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

1 line

Diff 44438

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Use selected button state on blame buttonClosedPublicActions