Page MenuHomePhabricator

Parse raw Ferret queries into tokens before processing them
ClosedPublic

Authored by epriestley on Aug 30 2017, 3:40 PM.
Tags
None
Referenced Files
F15529261: D18499.diff
Tue, Apr 22, 6:15 PM
F15516353: D18499.id44445.diff
Fri, Apr 18, 6:31 PM
F15478482: D18499.id44431.diff
Mon, Apr 7, 11:39 PM
F15457370: D18499.diff
Sun, Mar 30, 3:57 PM
F15448469: D18499.id44445.diff
Fri, Mar 28, 5:05 AM
F15448376: D18499.id44431.diff
Fri, Mar 28, 4:31 AM
F15434906: D18499.id.diff
Tue, Mar 25, 5:59 AM
F15430811: D18499.diff
Mar 24 2025, 9:06 AM
Subscribers
None

Details

Summary

Ref T12819. Depends on D18492. Instead of passing a raw query into the Query layer, parse it first.

This allows the query layer to figure out which parts should be substring vs term match, and would allow the SearchEngine layer to do author:... eventually by picking it out before sending it to the Ferret engine.

Test Plan

Ran some Ferret queries. They work like before, except that nonsense like -+"quack" raises an exception now.

Diff Detail

Repository
rP Phabricator
Branch
ferret6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18216
Build 24495: Run Core Tests
Build 24494: arc lint + arc unit