Page MenuHomePhabricator

Make legacy revision statuses from "differential.query" have type "string" again
ClosedPublic

Authored by epriestley on Aug 29 2017, 7:44 PM.
Tags
None
Referenced Files
F21199866: D18493.diff
Sun, Jul 5, 6:06 AM
Unknown Object (File)
Sat, Jun 27, 1:14 PM
Unknown Object (File)
Fri, Jun 26, 1:26 AM
Unknown Object (File)
Mon, Jun 22, 5:34 AM
Unknown Object (File)
Mon, Jun 22, 5:29 AM
Unknown Object (File)
Mon, Jun 22, 5:29 AM
Unknown Object (File)
Mon, Jun 22, 5:29 AM
Unknown Object (File)
Apr 17 2026, 3:21 AM
Subscribers
None

Details

Summary

Ref T2543. The type on these got changed by accident, it should be "string" (crazy nonsense, compatible) not "int" (sensible, not compatible).

(New API uses sensible strings like "accepted" only.)

Test Plan

Called differential.query from web UI, saw "2" and similar statuses.

Diff Detail

Repository
rP Phabricator
Branch
ptype
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18207
Build 24483: Run Core Tests
Build 24482: arc lint + arc unit