Page MenuHomePhabricator

Don't prompt to mark notifications as read if we don't need to
ClosedPublic

Authored by epriestley on Aug 28 2017, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 1:59 AM
Unknown Object (File)
Tue, Dec 24, 1:56 PM
Unknown Object (File)
Sun, Dec 22, 12:20 AM
Unknown Object (File)
Thu, Dec 19, 11:05 AM
Unknown Object (File)
Mon, Dec 16, 4:53 PM
Unknown Object (File)
Sat, Dec 14, 7:20 AM
Unknown Object (File)
Fri, Dec 13, 9:26 PM
Unknown Object (File)
Thu, Dec 12, 11:00 PM
Subscribers
None

Details

Summary

Fixes whatever task is tracking this junk, if one exists. Don't prompt unless there's a security issue.

Test Plan
  • Generated notifications from a test account.
  • Clicked "Mark All" from dropdown menu, no prompt.
  • Clicked "Mark All" from notifications screen, no prompt.
  • Command-Clicked "Mark All" from dropdown menu to open in new window, got normal prompt.

Diff Detail

Repository
rP Phabricator
Branch
noprompt
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18188
Build 24455: Run Core Tests
Build 24454: arc lint + arc unit