Page MenuHomePhabricator

Don't prompt to mark notifications as read if we don't need to
ClosedPublic

Authored by epriestley on Aug 28 2017, 7:18 PM.
Tags
None
Referenced Files
F14723669: D18483.id44401.diff
Sat, Jan 18, 12:34 AM
F14718191: D18483.id44402.diff
Fri, Jan 17, 8:14 PM
Unknown Object (File)
Sun, Jan 12, 3:59 PM
Unknown Object (File)
Sat, Jan 11, 5:31 PM
Unknown Object (File)
Fri, Jan 10, 7:00 PM
Unknown Object (File)
Sun, Jan 5, 7:57 AM
Unknown Object (File)
Sat, Jan 4, 9:17 PM
Unknown Object (File)
Fri, Jan 3, 5:21 AM
Subscribers
None

Details

Summary

Fixes whatever task is tracking this junk, if one exists. Don't prompt unless there's a security issue.

Test Plan
  • Generated notifications from a test account.
  • Clicked "Mark All" from dropdown menu, no prompt.
  • Clicked "Mark All" from notifications screen, no prompt.
  • Command-Clicked "Mark All" from dropdown menu to open in new window, got normal prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable