Page MenuHomePhabricator

Allow ModularTransactions to opt in to providing data to Conduit
ClosedPublic

Authored by epriestley on Aug 24 2017, 9:50 PM.
Tags
None
Referenced Files
F14105745: D18467.diff
Wed, Nov 27, 3:29 AM
Unknown Object (File)
Sat, Nov 23, 6:30 PM
Unknown Object (File)
Wed, Nov 20, 11:38 PM
Unknown Object (File)
Wed, Nov 20, 11:04 AM
Unknown Object (File)
Tue, Nov 12, 2:14 AM
Unknown Object (File)
Sun, Nov 10, 3:18 AM
Unknown Object (File)
Oct 16 2024, 9:00 PM
Unknown Object (File)
Oct 11 2024, 9:16 PM
Subscribers
None

Details

Summary

Ref T5873. See PHI14. I don't want to just expose internal transaction data to Conduit by default, since it's often: unstable, unusable, sensitive, or some combination of the three.

Instead, let ModularTransactions opt in to providing additional data to Conduit, similar to other infrastructure. If a transaction doesn't, the API returns an empty skeleton for it. This is generally fine since most transactions have no real use cases, and I think we can fill them in as we go.

This also probably builds toward T5726, which would likely use the same format, and perhaps simply not publish stuff which did not opt in.

This doesn't actually cover "comment" or "inline comment", which are presumably what PHI14 is after, since neither is modular. I'll probably just put a hack in place for this until they can modularize since I suspect modularizing them here is difficult.

Test Plan

Ran transaction.search on a revision, saw some transactions (title and status transactions) populate with values.

Diff Detail

Repository
rP Phabricator
Branch
xaction2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18149
Build 24396: Run Core Tests
Build 24395: arc lint + arc unit