Page MenuHomePhabricator

Add the skeleton for a "transaction.search" Conduit API method
ClosedPublic

Authored by epriestley on Aug 24 2017, 9:20 PM.
Tags
None
Referenced Files
F14073491: D18466.id44369.diff
Thu, Nov 21, 12:46 AM
F14073275: D18466.id.diff
Wed, Nov 20, 11:39 PM
Unknown Object (File)
Sun, Nov 10, 3:18 AM
Unknown Object (File)
Oct 20 2024, 11:20 AM
Unknown Object (File)
Oct 13 2024, 2:47 AM
Unknown Object (File)
Oct 13 2024, 12:01 AM
Unknown Object (File)
Oct 6 2024, 7:04 AM
Unknown Object (File)
Sep 20 2024, 9:27 AM
Subscribers
None

Details

Summary

Ref T5873. See PHI14. This does the basics that are shared across everything (IDs, PHIDs, dates, comments).

It doesn't do types (I think I don't necessarily want to expose internal types over the API?) or transaction-specific data.

In the next change, I'm going to add ways to let ModularTransactions "opt-in" to providing more data to Conduit. I'll use this to flesh out the actual desired transaction types (comments, presumably inline comments) and likely leave the rest as skeletons for now until use cases arise so we don't create a backward compatibility issue (or a security issue!) by exposing tons of internal stuff as public-facing API.

Test Plan

Ran queries, used paging. Retrieved an edited, deleted, and normal comment.

Screen Shot 2017-08-24 at 2.14.41 PM.png (1×1 px, 330 KB)

Diff Detail

Repository
rP Phabricator
Branch
xaction1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18148
Build 24394: Run Core Tests
Build 24393: arc lint + arc unit