Page MenuHomePhabricator

Add the skeleton for a "transaction.search" Conduit API method
ClosedPublic

Authored by epriestley on Aug 24 2017, 9:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 9:42 AM
Unknown Object (File)
Tue, Mar 5, 1:14 PM
Unknown Object (File)
Mon, Mar 4, 8:50 AM
Unknown Object (File)
Fri, Mar 1, 2:57 AM
Unknown Object (File)
Fri, Mar 1, 2:57 AM
Unknown Object (File)
Fri, Mar 1, 2:57 AM
Unknown Object (File)
Feb 21 2024, 10:21 AM
Unknown Object (File)
Feb 21 2024, 10:21 AM
Subscribers
None

Details

Summary

Ref T5873. See PHI14. This does the basics that are shared across everything (IDs, PHIDs, dates, comments).

It doesn't do types (I think I don't necessarily want to expose internal types over the API?) or transaction-specific data.

In the next change, I'm going to add ways to let ModularTransactions "opt-in" to providing more data to Conduit. I'll use this to flesh out the actual desired transaction types (comments, presumably inline comments) and likely leave the rest as skeletons for now until use cases arise so we don't create a backward compatibility issue (or a security issue!) by exposing tons of internal stuff as public-facing API.

Test Plan

Ran queries, used paging. Retrieved an edited, deleted, and normal comment.

Screen Shot 2017-08-24 at 2.14.41 PM.png (1×1 px, 330 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable