Page MenuHomePhabricator

Remove rows for personal saved builtin queries
ClosedPublic

Authored by epriestley on Aug 24 2017, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 11:01 AM
Unknown Object (File)
Feb 10 2024, 9:36 AM
Unknown Object (File)
Jan 25 2024, 4:42 AM
Unknown Object (File)
Jan 1 2024, 10:26 AM
Unknown Object (File)
Dec 27 2023, 11:56 AM
Unknown Object (File)
Dec 27 2023, 11:56 AM
Unknown Object (File)
Dec 27 2023, 11:56 AM
Unknown Object (File)
Dec 21 2023, 8:46 PM
Subscribers
None

Details

Summary

Ref T12956. After this change, individual users will no longer be able to modify builtin queries on a user-by-user basis: they will always appear at the bottom of the list, under their personal queries, and can only be managed by administrators.

To support this, clean up the old rows which could be hanging around from before: delete any personal saved queries where the saved query is a builtin query.

To ease this transition, try to pin the query we're deleting if the user had reordered things to put it on top.

Test Plan
  • Ran the migration, saw no changes in the UI but fewer rows.
  • Went back to master, reordered queries to put a builtin one on top.
  • Ran the migration.
  • Saw that builtin one drop to the bottom (since it can't be on top anymore) but be pinned, preserving the behavior of /maniphest/.

Diff Detail

Repository
rP Phabricator
Branch
item4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18146
Build 24390: Run Core Tests
Build 24389: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 24 2017, 8:52 PM
This revision was automatically updated to reflect the committed changes.