Page MenuHomePhabricator

Separate saved queries in applications into "personal" and "global" queries

Authored by epriestley on Aug 14 2017, 8:15 PM.
Referenced Files
Fri, Sep 22, 6:40 AM
F12186669: D18426.diff
Sun, Sep 17, 12:48 AM
F12183147: D18426.diff
Thu, Sep 14, 6:21 AM
F12166983: D18426.diff
Thu, Sep 7, 2:14 AM
F12137345: D18426.id44366.diff
Aug 26 2023, 8:45 PM
Aug 21 2023, 5:46 PM
Unknown Object (File)
Jul 10 2023, 9:40 AM
Unknown Object (File)
Jun 26 2023, 4:22 PM



Ref T12956. UI changes:

  • Administrators get a new [X] Save as global query option when saving a query.
  • "Edit Queries..." is split into "Personal" and "Global" sections. For administrators, each section can be edited. For non-admins, only the top section can be edited, but any query can be pinned.

A couple notes:

  • This doesn't support "pin for everyone by default". New users just get the first query from the bottom set. That seems reasonable for now.
  • Reordering is currently a little buggy (it works if you've reordered before, but not if you're reordering for the first time), but I need to migrate before I can fix / test that properly. So that'll get cleaned up in the next change or two.
Test Plan
  • As an admin and non-admin, viewed, edited, disabled, saved-as-personal and saved-as-global various queries.

Screen Shot 2017-08-14 at 1.12.32 PM.png (758×1 px, 104 KB)

Screen Shot 2017-08-14 at 1.11.45 PM.png (970×1 px, 153 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable