Page MenuHomePhabricator

Migrate revision storage to modern status constants ("accepted") instead of legacy numeric values ("2")
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 2:01 AM
Unknown Object (File)
Feb 10 2024, 8:38 PM
Unknown Object (File)
Feb 10 2024, 3:24 PM
Unknown Object (File)
Feb 1 2024, 11:06 PM
Unknown Object (File)
Dec 27 2023, 11:52 AM
Unknown Object (File)
Dec 27 2023, 11:52 AM
Unknown Object (File)
Dec 27 2023, 11:52 AM
Unknown Object (File)
Dec 21 2023, 8:35 PM
Subscribers
None

Details

Summary

Ref T2543. Rewrites all the storage to use constants.

Note that transactions still use legacy values, I'll migrate and update them separately.

Test Plan
  • Ran migration.
  • Browsed around, changed revision states, viewed dashboard, etc.
  • Selected DISTINCT() and GROUP_CONCAT() of the status field in the database, saw sane/expected before and after values.
  • Verified that old Conduit methods still return numeric constants for compatibility.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable