Paths

Table of Contentst

Differential D18418

Migrate revision storage to modern status constants ("accepted") instead of legacy numeric values ("2")
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 11:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 6:33 AM

	Unknown Object (File)
	Thu, Dec 12, 8:56 AM

	Unknown Object (File)
	Thu, Dec 12, 8:56 AM

	Unknown Object (File)
	Thu, Dec 12, 8:56 AM

	Unknown Object (File)
	Sat, Dec 7, 6:55 AM

	Unknown Object (File)
	Fri, Dec 6, 2:12 PM

	Unknown Object (File)
	Nov 12 2024, 4:14 PM

	Unknown Object (File)
	Nov 8 2024, 8:14 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP7b695aa43bd1: Migrate revision storage to modern status constants ("accepted") instead of…

Summary

Ref T2543. Rewrites all the storage to use constants.

Note that transactions still use legacy values, I'll migrate and update them separately.

Test Plan

Ran migration.
Browsed around, changed revision states, viewed dashboard, etc.
Selected DISTINCT() and GROUP_CONCAT() of the status field in the database, saw sane/expected before and after values.
Verified that old Conduit methods still return numeric constants for compatibility.

Diff Detail

Repository

Branch

status19

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18045
Build 24240: Run Core Tests
Build 24239: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 11 2017, 11:34 PM

Harbormaster completed remote builds in B18045: Diff 44253.Aug 11 2017, 11:35 PM

epriestley edited the summary of this revision. (Show Details)Aug 11 2017, 11:36 PM

chad accepted this revision.Aug 11 2017, 11:53 PM

This revision is now accepted and ready to land.Aug 11 2017, 11:53 PM

Closed by commit rP7b695aa43bd1: Migrate revision storage to modern status constants ("accepted") instead of… (authored by epriestley). · Explain WhyAug 12 2017, 11:02 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.Aug 12 2017, 11:17 AM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20170811.differential.02.modernstatus.sql

17 lines

src/

applications/

differential/

constants/

DifferentialLegacyQuery.php

15 lines

query/

DifferentialRevisionQuery.php

4 lines

storage/

DifferentialRevision.php

19 lines

xaction/

DifferentialRevisionStatusTransaction.php

3 lines

Diff 44253

resources/sql/autopatches/20170811.differential.02.modernstatus.sql

Loading...

src/applications/differential/constants/DifferentialLegacyQuery.php

Loading...

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/differential/xaction/DifferentialRevisionStatusTransaction.php

Loading...