Page MenuHomePhabricator

Migrate revision storage to modern status constants ("accepted") instead of legacy numeric values ("2")
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:34 PM.

Details

Summary

Ref T2543. Rewrites all the storage to use constants.

Note that transactions still use legacy values, I'll migrate and update them separately.

Test Plan
  • Ran migration.
  • Browsed around, changed revision states, viewed dashboard, etc.
  • Selected DISTINCT() and GROUP_CONCAT() of the status field in the database, saw sane/expected before and after values.
  • Verified that old Conduit methods still return numeric constants for compatibility.

Diff Detail

Repository
rP Phabricator
Branch
status19
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18045
Build 24240: Run Core Tests
Build 24239: arc lint + arc unit