Page MenuHomePhabricator

Migrate revision storage to modern status constants ("accepted") instead of legacy numeric values ("2")
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:34 PM.
Tags
None
Referenced Files
F15459676: D18418.id44253.diff
Mon, Mar 31, 3:04 PM
F15455404: D18418.id44262.diff
Sun, Mar 30, 12:10 AM
F15451677: D18418.id.diff
Fri, Mar 28, 11:17 PM
F15444674: D18418.diff
Thu, Mar 27, 10:41 AM
F15414786: D18418.diff
Thu, Mar 20, 2:32 AM
F15400240: D18418.id44253.diff
Mon, Mar 17, 10:29 AM
F15396676: D18418.id44262.diff
Sun, Mar 16, 3:47 PM
F15384816: D18418.id44262.diff
Fri, Mar 14, 8:56 PM
Subscribers
None

Details

Summary

Ref T2543. Rewrites all the storage to use constants.

Note that transactions still use legacy values, I'll migrate and update them separately.

Test Plan
  • Ran migration.
  • Browsed around, changed revision states, viewed dashboard, etc.
  • Selected DISTINCT() and GROUP_CONCAT() of the status field in the database, saw sane/expected before and after values.
  • Verified that old Conduit methods still return numeric constants for compatibility.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable