Page MenuHomePhabricator

Migrate revision storage to modern status constants ("accepted") instead of legacy numeric values ("2")
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:34 PM.

Details

Summary

Ref T2543. Rewrites all the storage to use constants.

Note that transactions still use legacy values, I'll migrate and update them separately.

Test Plan
  • Ran migration.
  • Browsed around, changed revision states, viewed dashboard, etc.
  • Selected DISTINCT() and GROUP_CONCAT() of the status field in the database, saw sane/expected before and after values.
  • Verified that old Conduit methods still return numeric constants for compatibility.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 11 2017, 11:34 PM
epriestley edited the summary of this revision. (Show Details)Aug 11 2017, 11:36 PM
chad accepted this revision.Aug 11 2017, 11:53 PM
This revision is now accepted and ready to land.Aug 11 2017, 11:53 PM
This revision was automatically updated to reflect the committed changes.