Page MenuHomePhabricator

Modularize remaining TYPE_ACTION transactions in Differential, reducing calls to ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 10:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 29, 6:15 PM
Unknown Object (File)
Thu, Dec 26, 6:48 PM
Unknown Object (File)
Thu, Dec 12, 7:09 PM
Unknown Object (File)
Wed, Dec 11, 2:36 PM
Unknown Object (File)
Sun, Dec 8, 6:10 PM
Unknown Object (File)
Wed, Dec 4, 10:00 PM
Unknown Object (File)
Nov 30 2024, 2:56 PM
Unknown Object (File)
Nov 12 2024, 4:15 PM
Subscribers
None

Details

Summary

Ref T2543. This cleans up a couple of remaining rough edges:

  • We could do an older TYPE_ACTION "close" via the daemons.
  • We could do an older TYPE_ACTION "close" via arc close-revision, explicitly or implicitly in arc land, via API (differential.close).
  • We could do an older TYPE_ACTION "rethink" ("Plan Changes") via the API, via arc diff --plan-changes (differential.createcomment).

Move these to modern modular transactions, then get rid of all the validation and application logic for them. This nukes a bunch of ArcanistDifferentialRevision::... junk.

Test Plan
  • Used bin/repository reparse --message rXYZ... to reparse a commit, closing a corresponding revision.
  • Used differential.close to close a revision.
  • Used differential.createcomment to plan changes to a revision.
  • Reviewed transaction log for full "closed by commit" message (linking to commit and mentioning author).
  • Grepped for ::TYPE_ACTION to look for remaining callsites, didn't find any.
  • Grepped for differential.close and differential.createcomment in arcanist/ to look for anything suspicious, seemed clean.

Diff Detail

Repository
rP Phabricator
Branch
status13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18039
Build 24228: Run Core Tests
Build 24227: arc lint + arc unit