Page MenuHomePhabricator

Modularize remaining TYPE_ACTION transactions in Differential, reducing calls to ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 10:18 PM.
Tags
None
Referenced Files
F15510864: D18412.id.diff
Wed, Apr 16, 9:38 PM
F15466596: D18412.id44247.diff
Thu, Apr 3, 7:20 AM
F15453747: D18412.id44256.diff
Sat, Mar 29, 2:03 PM
F15450903: D18412.id.diff
Fri, Mar 28, 6:54 PM
F15445721: D18412.diff
Thu, Mar 27, 3:41 PM
F15420536: D18412.diff
Fri, Mar 21, 2:44 PM
Unknown Object (File)
Feb 20 2025, 7:11 PM
Unknown Object (File)
Feb 12 2025, 10:25 PM
Subscribers
None

Details

Summary

Ref T2543. This cleans up a couple of remaining rough edges:

  • We could do an older TYPE_ACTION "close" via the daemons.
  • We could do an older TYPE_ACTION "close" via arc close-revision, explicitly or implicitly in arc land, via API (differential.close).
  • We could do an older TYPE_ACTION "rethink" ("Plan Changes") via the API, via arc diff --plan-changes (differential.createcomment).

Move these to modern modular transactions, then get rid of all the validation and application logic for them. This nukes a bunch of ArcanistDifferentialRevision::... junk.

Test Plan
  • Used bin/repository reparse --message rXYZ... to reparse a commit, closing a corresponding revision.
  • Used differential.close to close a revision.
  • Used differential.createcomment to plan changes to a revision.
  • Reviewed transaction log for full "closed by commit" message (linking to commit and mentioning author).
  • Grepped for ::TYPE_ACTION to look for remaining callsites, didn't find any.
  • Grepped for differential.close and differential.createcomment in arcanist/ to look for anything suspicious, seemed clean.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable