Page MenuHomePhabricator

Modularize remaining TYPE_ACTION transactions in Differential, reducing calls to ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 10:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 4:19 PM
Unknown Object (File)
Mon, Apr 8, 4:10 PM
Unknown Object (File)
Sat, Apr 6, 3:34 PM
Unknown Object (File)
Mon, Apr 1, 5:19 AM
Unknown Object (File)
Sat, Mar 30, 4:58 AM
Unknown Object (File)
Mar 12 2024, 10:08 PM
Unknown Object (File)
Feb 22 2024, 12:40 PM
Unknown Object (File)
Feb 22 2024, 9:21 AM
Subscribers
None

Details

Summary

Ref T2543. This cleans up a couple of remaining rough edges:

  • We could do an older TYPE_ACTION "close" via the daemons.
  • We could do an older TYPE_ACTION "close" via arc close-revision, explicitly or implicitly in arc land, via API (differential.close).
  • We could do an older TYPE_ACTION "rethink" ("Plan Changes") via the API, via arc diff --plan-changes (differential.createcomment).

Move these to modern modular transactions, then get rid of all the validation and application logic for them. This nukes a bunch of ArcanistDifferentialRevision::... junk.

Test Plan
  • Used bin/repository reparse --message rXYZ... to reparse a commit, closing a corresponding revision.
  • Used differential.close to close a revision.
  • Used differential.createcomment to plan changes to a revision.
  • Reviewed transaction log for full "closed by commit" message (linking to commit and mentioning author).
  • Grepped for ::TYPE_ACTION to look for remaining callsites, didn't find any.
  • Grepped for differential.close and differential.createcomment in arcanist/ to look for anything suspicious, seemed clean.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable