Page MenuHomePhabricator

Modularize remaining TYPE_ACTION transactions in Differential, reducing calls to ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 10:18 PM.
Tags
None
Referenced Files
F18508998: D18412.id.diff
Fri, Sep 5, 3:09 AM
F18501415: D18412.diff
Thu, Sep 4, 9:44 PM
F18467641: D18412.diff
Tue, Sep 2, 1:13 PM
F18094885: D18412.id.diff
Aug 7 2025, 10:24 PM
F18093016: D18412.id44247.diff
Aug 7 2025, 2:47 PM
F17947766: D18412.id.diff
Jul 31 2025, 6:26 PM
F17889622: D18412.id.diff
Jul 29 2025, 2:48 AM
F17870970: D18412.diff
Jul 28 2025, 3:06 PM
Subscribers
None

Details

Summary

Ref T2543. This cleans up a couple of remaining rough edges:

  • We could do an older TYPE_ACTION "close" via the daemons.
  • We could do an older TYPE_ACTION "close" via arc close-revision, explicitly or implicitly in arc land, via API (differential.close).
  • We could do an older TYPE_ACTION "rethink" ("Plan Changes") via the API, via arc diff --plan-changes (differential.createcomment).

Move these to modern modular transactions, then get rid of all the validation and application logic for them. This nukes a bunch of ArcanistDifferentialRevision::... junk.

Test Plan
  • Used bin/repository reparse --message rXYZ... to reparse a commit, closing a corresponding revision.
  • Used differential.close to close a revision.
  • Used differential.createcomment to plan changes to a revision.
  • Reviewed transaction log for full "closed by commit" message (linking to commit and mentioning author).
  • Grepped for ::TYPE_ACTION to look for remaining callsites, didn't find any.
  • Grepped for differential.close and differential.createcomment in arcanist/ to look for anything suspicious, seemed clean.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable