Update AphlictClientServer to support ws2 or ws3
ClosedPublic
Actions

Authored by chad on Aug 11 2017, 10:03 PM.

Tags

None

Referenced Files

	F15537455: D18411.id44246.diff
	Thu, Apr 24, 1:48 PM

	F15534678: D18411.diff
	Thu, Apr 24, 1:15 AM

	F15514358: D18411.id44246.diff
	Fri, Apr 18, 2:13 AM

	F15500349: D18411.id44245.diff
	Sun, Apr 13, 5:30 PM

	F15486744: D18411.id44246.diff
	Thu, Apr 10, 9:23 AM

	F15484512: D18411.id.diff
	Wed, Apr 9, 6:43 PM

	F15479908: D18411.diff
	Tue, Apr 8, 10:09 AM

	F15471695: D18411.diff
	Sat, Apr 5, 7:29 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12755: Aphlict doesn't work with the latest version of `ws`

Commits

rP3b14c1fdd1cf: Update AphlictClientServer to support ws2 or ws3

Summary

This lets us support either ws2 or ws3. Fixes T12755

Test Plan

Update server to version 3, send message, watch debug log. Downgrade to 2.x, send messages, watch debug log. Everything seems OK

Diff Detail

Repository

rP Phabricator

Branch

aphlict-server (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18037
Build 24225: Run Core Tests
Build 24224: arc lint + arc unit

Event Timeline

chad created this revision.Aug 11 2017, 10:03 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 11 2017, 10:03 PM

Harbormaster completed remote builds in B18037: Diff 44245.Aug 11 2017, 10:03 PM

Harbormaster completed remote builds in B18037: Diff 44245.

Consider leaving a comment about this pointing at T12755, it's not very obvious on its own.

This revision is now accepted and ready to land.Aug 11 2017, 10:12 PM

Closed by commit rP3b14c1fdd1cf: Update AphlictClientServer to support ws2 or ws3 (authored by chad, committed by chad). · Explain WhyAug 11 2017, 10:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

aphlict/

server/

lib/

AphlictClientServer.js

8 lines

Diff 44245

View Options

support/aphlict/server/lib/AphlictClientServer.js

Update AphlictClientServer to support ws2 or ws3ClosedPublicActions