Page MenuHomePhabricator

Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 9:39 PM.
Tags
None
Referenced Files
F18089175: D18410.id44255.diff
Wed, Aug 6, 10:35 AM
F18084688: D18410.id.diff
Tue, Aug 5, 4:48 PM
F18048734: D18410.diff
Sun, Aug 3, 1:57 PM
F17842488: D18410.id44255.diff
Sat, Jul 26, 11:42 PM
F17827247: D18410.id44244.diff
Sat, Jul 26, 8:04 AM
F17814831: D18410.diff
Fri, Jul 25, 9:32 PM
Unknown Object (File)
Jul 3 2025, 10:13 AM
Unknown Object (File)
Jun 29 2025, 8:01 PM
Subscribers
None

Details

Summary

Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses every color.

Test Plan

Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable