Page MenuHomePhabricator

Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus

Authored by epriestley on Aug 11 2017, 9:39 PM.



Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses every color.

Test Plan

Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 11 2017, 9:39 PM
chad accepted this revision.Aug 11 2017, 10:22 PM
This revision is now accepted and ready to land.Aug 11 2017, 10:22 PM
This revision was automatically updated to reflect the committed changes.