Page MenuHomePhabricator

Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 2:49 AM
Unknown Object (File)
Wed, Feb 19, 3:16 PM
Unknown Object (File)
Fri, Feb 14, 1:57 AM
Unknown Object (File)
Mon, Feb 10, 11:05 PM
Unknown Object (File)
Sat, Feb 8, 2:36 AM
Unknown Object (File)
Mon, Feb 3, 2:50 AM
Unknown Object (File)
Jan 28 2025, 1:16 PM
Unknown Object (File)
Jan 28 2025, 1:45 AM
Subscribers
None

Details

Summary

Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses every color.

Test Plan

Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable