Differential D18394

Migrate Differential Revision SavedQueries to the new "statuses" tokenizer
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 4:06 PM.

Tags

None

Referenced Files

	F13174076: D18394.id44235.diff
	Tue, May 7, 9:59 PM

	Unknown Object (File)
	Tue, May 7, 6:12 AM

	Unknown Object (File)
	Fri, May 3, 3:52 AM

	Unknown Object (File)
	Mon, Apr 29, 3:56 PM

	Unknown Object (File)
	Wed, Apr 24, 11:50 PM

	Unknown Object (File)
	Fri, Apr 19, 6:42 PM

	Unknown Object (File)
	Tue, Apr 16, 10:45 PM

	Unknown Object (File)
	Mon, Apr 15, 7:12 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP212d4d0dc753: Migrate Differential Revision SavedQueries to the new "statuses" tokenizer

Summary

Ref T2543. This migrates existing saved queries so they use the right modern values for the new tokenizer control, introduced in D18393.

Test Plan

Saved a query with "Abandoned" selected as the status in the old "<select />", prior to D18393.
Upgraded to D18393, which broke the query (it no longer selected any status filter).
Ran the migration to fix things.
Saw the query now execute with "Abandoned" selected in the tokenizer, preseving the original behavior accurately.

Diff Detail

Repository

Branch

status3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18007
Build 24185: Run Core Tests
Build 24184: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 11 2017, 4:06 PM

Harbormaster completed remote builds in B18007: Diff 44209.Aug 11 2017, 4:08 PM

epriestley edited the test plan for this revision. (Show Details)Aug 11 2017, 4:11 PM

chad accepted this revision.Aug 11 2017, 5:01 PM

This revision is now accepted and ready to land.Aug 11 2017, 5:01 PM

Closed by commit rP212d4d0dc753: Migrate Differential Revision SavedQueries to the new "statuses" tokenizer (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2017, 8:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20170811.differential.01.status.php

48 lines

Diff 44209

resources/sql/autopatches/20170811.differential.01.status.php

Loading...