Page MenuHomePhabricator

Replace Differential hard-coded status "<select />" with tokenizer
ClosedPublic

Authored by epriestley on Aug 11 2017, 3:13 PM.
Tags
None
Referenced Files
F15484204: D18393.id44208.diff
Wed, Apr 9, 5:05 PM
F15462292: D18393.id44234.diff
Tue, Apr 1, 1:45 PM
F15457986: D18393.id44207.diff
Sun, Mar 30, 8:22 PM
F15457109: D18393.id.diff
Sun, Mar 30, 2:25 PM
F15456191: D18393.diff
Sun, Mar 30, 7:43 AM
F15454053: D18393.id44208.diff
Sat, Mar 29, 4:00 PM
F15447176: D18393.diff
Thu, Mar 27, 10:19 PM
F15405560: D18393.diff
Mar 18 2025, 11:37 AM
Subscribers
None
Tokens
"Cup of Joe" token, awarded by chad.

Details

Summary

Ref T2543. This updates the UI control in the web UI. Also:

  • This implicitly makes this queryable with the API (differential.revision.search); it previously was not.
  • This does NOT migrate existing saved queries. I'll do those in the next change, and hold this until it happens.
  • This will break some existing /differential/?status=XYZ links. For example, status=open now needs to be status=open(). I couldn't find any of these in the upstream, and I suspect these are rare in the wild (users would normally link directly to saved queries, not use URI query construction).
Test Plan

Screen Shot 2017-08-11 at 8.09.44 AM.png (155×412 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable