Page MenuHomePhabricator

Replace Differential hard-coded status "<select />" with tokenizer
ClosedPublic

Authored by epriestley on Aug 11 2017, 3:13 PM.
Tags
None
Referenced Files
F13087465: D18393.diff
Thu, Apr 25, 12:59 AM
Unknown Object (File)
Fri, Apr 19, 6:42 PM
Unknown Object (File)
Mon, Apr 15, 7:18 AM
Unknown Object (File)
Mon, Apr 15, 7:18 AM
Unknown Object (File)
Thu, Apr 11, 8:44 AM
Unknown Object (File)
Thu, Apr 11, 1:10 AM
Unknown Object (File)
Wed, Apr 10, 9:13 PM
Unknown Object (File)
Wed, Apr 10, 4:33 PM
Subscribers
None
Tokens
"Cup of Joe" token, awarded by chad.

Details

Summary

Ref T2543. This updates the UI control in the web UI. Also:

  • This implicitly makes this queryable with the API (differential.revision.search); it previously was not.
  • This does NOT migrate existing saved queries. I'll do those in the next change, and hold this until it happens.
  • This will break some existing /differential/?status=XYZ links. For example, status=open now needs to be status=open(). I couldn't find any of these in the upstream, and I suspect these are rare in the wild (users would normally link directly to saved queries, not use URI query construction).
Test Plan

Screen Shot 2017-08-11 at 8.09.44 AM.png (155×412 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable