Page MenuHomePhabricator

Replace Differential hard-coded status "<select />" with tokenizer
ClosedPublic

Authored by epriestley on Aug 11 2017, 3:13 PM.
Tags
None
Referenced Files
F18508985: D18393.id.diff
Fri, Sep 5, 3:08 AM
F18501388: D18393.diff
Thu, Sep 4, 9:43 PM
F18464425: D18393.id44234.diff
Tue, Sep 2, 4:23 AM
F18321401: D18393.diff
Sun, Aug 24, 4:53 PM
F18094874: D18393.id.diff
Aug 7 2025, 10:24 PM
F17859615: D18393.id44207.diff
Jul 27 2025, 8:55 PM
F17846259: D18393.id44207.diff
Jul 27 2025, 4:36 AM
F17844723: D18393.id44208.diff
Jul 27 2025, 2:29 AM
Subscribers
None
Tokens
"Cup of Joe" token, awarded by chad.

Details

Summary

Ref T2543. This updates the UI control in the web UI. Also:

  • This implicitly makes this queryable with the API (differential.revision.search); it previously was not.
  • This does NOT migrate existing saved queries. I'll do those in the next change, and hold this until it happens.
  • This will break some existing /differential/?status=XYZ links. For example, status=open now needs to be status=open(). I couldn't find any of these in the upstream, and I suspect these are rare in the wild (users would normally link directly to saved queries, not use URI query construction).
Test Plan

Screen Shot 2017-08-11 at 8.09.44 AM.png (155×412 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable