Page MenuHomePhabricator
Differential D18350

Hide curtainview on mobile if it's empty
ClosedPublic
Actions

Authored by chad on Aug 6 2017, 3:06 AM.
Tags
None
Referenced Files
F15473832: D18350.id44108.diff
Sun, Apr 6, 1:56 AM
F15443845: D18350.id44108.diff
Thu, Mar 27, 6:29 AM
Unknown Object (File)
Feb 3 2025, 2:52 PM
Unknown Object (File)
Jan 23 2025, 7:49 AM
Unknown Object (File)
Jan 23 2025, 6:33 AM
Unknown Object (File)
Dec 21 2024, 4:36 AM
Unknown Object (File)
Dec 17 2024, 10:05 AM
Unknown Object (File)
Dec 8 2024, 1:42 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP58db64c81f5c: Hide curtainview on mobile if it's empty
Summary

If we don't have any panels, just an action list, we want to hide the entire box on mobile since it's just an empty line.

Test Plan

Review Owners, Differential curtains on mobile, desktop.

Diff Detail

Repository
rP Phabricator
Branch
mobile-curtain (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17923
Build 24073: Run Core Tests
Build 24072: arc lint + arc unit

Event Timeline

chad created this revision.Aug 6 2017, 3:06 AM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 6 2017, 3:06 AM
Harbormaster completed remote builds in B17923: Diff 44104.Aug 6 2017, 3:07 AM
epriestley accepted this revision.Aug 6 2017, 11:44 AM
This revision is now accepted and ready to land.Aug 6 2017, 11:44 AM
Closed by commit rP58db64c81f5c: Hide curtainview on mobile if it's empty (authored by chad, committed by chad). · Explain WhyAug 6 2017, 3:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
layout/
9 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 44104

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/PHUICurtainView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-curtain-view.css

Loading...
Phabricator · Built by Phacility