Page MenuHomePhabricator
Differential D18350

Hide curtainview on mobile if it's empty
ClosedPublic
Actions

Authored by chad on Aug 6 2017, 3:06 AM.
Tags
None
Referenced Files
F15573545: D18350.id44104.diff
Mon, May 5, 9:13 PM
F15573393: D18350.id44108.diff
Mon, May 5, 8:43 PM
F15540401: D18350.diff
Fri, Apr 25, 7:22 AM
F15524490: D18350.id44104.diff
Mon, Apr 21, 8:19 AM
F15522013: D18350.id44108.diff
Sun, Apr 20, 5:25 PM
F15514873: D18350.diff
Fri, Apr 18, 6:11 AM
F15505834: D18350.diff
Tue, Apr 15, 6:16 AM
F15476032: D18350.id44104.diff
Apr 7 2025, 2:37 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP58db64c81f5c: Hide curtainview on mobile if it's empty
Summary

If we don't have any panels, just an action list, we want to hide the entire box on mobile since it's just an empty line.

Test Plan

Review Owners, Differential curtains on mobile, desktop.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Aug 6 2017, 3:06 AM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 6 2017, 3:06 AM
Harbormaster completed remote builds in B17923: Diff 44104.Aug 6 2017, 3:07 AM
epriestley accepted this revision.Aug 6 2017, 11:44 AM
This revision is now accepted and ready to land.Aug 6 2017, 11:44 AM
Closed by commit rP58db64c81f5c: Hide curtainview on mobile if it's empty (authored by chad, committed by chad). · Explain WhyAug 6 2017, 3:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
layout/
9 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 44108

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/PHUICurtainView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-curtain-view.css

Loading...
Phabricator · Built by Phacility