Page MenuHomePhabricator

Reduce STATUS_CLOSED (now internally "Published") revision status callsites
ClosedPublic

Authored by epriestley on Aug 4 2017, 3:23 PM.
Tags
None
Referenced Files
F14745862: D18341.diff
Tue, Jan 21, 9:34 AM
Unknown Object (File)
Sat, Jan 18, 2:14 PM
Unknown Object (File)
Fri, Jan 17, 3:12 PM
Unknown Object (File)
Fri, Jan 17, 8:46 AM
Unknown Object (File)
Fri, Jan 3, 2:43 PM
Unknown Object (File)
Tue, Dec 31, 11:38 PM
Unknown Object (File)
Dec 22 2024, 6:48 PM
Unknown Object (File)
Dec 11 2024, 10:07 PM
Subscribers
None

Details

Summary

Ref T2543. Add isPublished() to mean: exactly the status 'closed', which is now interally called 'published', but still shown as 'closed' to users.

We have some callsites which are about "exactly that status", vs "any 'closed' status", e.g. including "abandoned".

This also introduces isChangePlanned(), which felt less awkward than isChangesPlanned() but more consistent than hasChangesPlanned() or isStatusChangesPlanned() or similar.

Test Plan

grep, loaded revisions, requested review.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable