Page MenuHomePhabricator

Reduce STATUS_CLOSED (now internally "Published") revision status callsites
ClosedPublic

Authored by epriestley on Aug 4 2017, 3:23 PM.
Tags
None
Referenced Files
F15576986: D18341.id44094.diff
Tue, May 6, 11:40 AM
F15565602: D18341.id44160.diff
Thu, May 1, 4:47 AM
F15565599: D18341.id44094.diff
Thu, May 1, 4:46 AM
F15565597: D18341.id.diff
Thu, May 1, 4:46 AM
F15559758: D18341.diff
Tue, Apr 29, 10:20 AM
F15521458: D18341.id44160.diff
Sun, Apr 20, 2:27 PM
F15507701: D18341.diff
Tue, Apr 15, 10:02 PM
F15504915: D18341.diff
Mon, Apr 14, 10:28 PM
Subscribers
None

Details

Summary

Ref T2543. Add isPublished() to mean: exactly the status 'closed', which is now interally called 'published', but still shown as 'closed' to users.

We have some callsites which are about "exactly that status", vs "any 'closed' status", e.g. including "abandoned".

This also introduces isChangePlanned(), which felt less awkward than isChangesPlanned() but more consistent than hasChangesPlanned() or isStatusChangesPlanned() or similar.

Test Plan

grep, loaded revisions, requested review.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable