When providing lint results in specific files on Windows, handle slash differences so that Arcanist has the correct references to provide things such as inline comments in Differential.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers
arc lint and subsequent revision submission on files resident on Windows, note correct display of lint results with links.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- win
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 17888 Build 24023: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 889 ms | ArcanistFlake8LinterTestCase::Unknown Unit Message (" ") In 'undefined.lint-test', lint raised error on line 1 at char 1, but nothing was expected:
Missing docstring in public module
| |
| 2,333 ms | ArcanistJSHintLinterTestCase::Unknown Unit Message (" ") In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised:
warning at line 3, char 8: W033 JSHintW033
error at line 7, char 1: E019 JSHintE019
| |
| 20 ms | ArcanistChmodLinterTestCase::Unknown Unit Message (" ") 5 assertions passed. | |
| 0 ms | ArcanistClosureLinterTestCase::Unknown Unit Message (" ") 1 assertion passed. | |
| 0 ms | ArcanistCpplintLinterTestCase::Unknown Unit Message (" ") 1 assertion passed. | |
| View Full Test Results (2 Failed · 27 Passed · 25 Skipped) |
Event Timeline
Comment Actions
@epriestley are code contributions no longer accepted? We don't consider this something related to a bug report per se.
Comment Actions
See Contributing Code.
The barrier for contributions is extremely high. In almost all cases where users write code nowadays, it would save us time if they just reported a bug with reproduction instructions instead, since we almost always need this information anyway and sending a patch without this information just adds more overhead.
This is probably one of those cases. There's no associated task describing what the actual problem is, and from the description alone, I don't really know what problem this solves, how to reproduce the issue, etc. Since I don't know what the actual goal is here, I'm not really sure if this is a reasonable fix or not.
Offhand, I'd guess it probably isn't the best fix we could come up with. One aspect of this change which I'm uneasy about, and which might be a bit of a red flag, is that we're destroying information fairly early in the pipeline. Often, it's better to preserve information for as long as possible and normalize it at the last moment. I'm not sure if that applies here or not, but I'd want to look at ways we might be able to retain the original path information for as long as possible.
See also Planning.
Comment Actions
Thanks, been a while since we tried to do this. Bug report submitted at https://discourse.phabricator-community.org/t/inline-comments-not-generated-for-lint-results-when-uploaded-from-windows/377.