Page MenuHomePhabricator

Move Phabricator to use PhutilBinaryAnalyzer and show binary versions
ClosedPublic

Authored by epriestley on Jul 31 2017, 7:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 4:19 PM
Unknown Object (File)
Fri, Apr 19, 2:36 AM
Unknown Object (File)
Fri, Apr 19, 2:36 AM
Unknown Object (File)
Fri, Apr 19, 2:36 AM
Unknown Object (File)
Mon, Apr 15, 12:24 PM
Unknown Object (File)
Thu, Apr 11, 7:30 AM
Unknown Object (File)
Thu, Apr 11, 3:57 AM
Unknown Object (File)
Mar 21 2024, 7:33 AM
Subscribers

Details

Summary

Fixes T12942.

  • Adds binary version and path information to ConfigVersion Information.
  • Replaces old code all over the place with new consolidated code.
Test Plan

Screen Shot 2017-07-31 at 12.14.42 PM.png (341×777 px, 101 KB)

Also faked some cases of missing binaries, bad versions, etc.

Diff Detail

Repository
rP Phabricator
Branch
version2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17852
Build 23979: Run Core Tests
Build 23978: arc lint + arc unit

Unit TestsFailed

TimeTest
41 msPhabricatorChangeParserTestCase::Unknown Unit Message ("")
EXCEPTION (PhutilMissingSymbolException): Failed to load class or interface 'PhutilBinaryAnalyzer': the class or interface 'PhutilBinaryAnalyzer' is not defined in the library map for any loaded phutil library. If you are not a developer, this almost always means that a library is out of date. For example, you may have upgraded `phabricator` without upgrading `libphutil`, or vice versa. It might also mean that you need to restart Apache or PHP-FPM. Make sure all libraries are up to date and all services have been restarted.
41 msPhabricatorWorkingCopyDiscoveryTestCase::Unknown Unit Message ("")
EXCEPTION (PhutilMissingSymbolException): Failed to load class or interface 'PhutilBinaryAnalyzer': the class or interface 'PhutilBinaryAnalyzer' is not defined in the library map for any loaded phutil library. If you are not a developer, this almost always means that a library is out of date. For example, you may have upgraded `phabricator` without upgrading `libphutil`, or vice versa. It might also mean that you need to restart Apache or PHP-FPM. Make sure all libraries are up to date and all services have been restarted.
44 msPhabricatorWorkingCopyPullTestCase::Unknown Unit Message ("")
EXCEPTION (PhutilMissingSymbolException): Failed to load class or interface 'PhutilBinaryAnalyzer': the class or interface 'PhutilBinaryAnalyzer' is not defined in the library map for any loaded phutil library. If you are not a developer, this almost always means that a library is out of date. For example, you may have upgraded `phabricator` without upgrading `libphutil`, or vice versa. It might also mean that you need to restart Apache or PHP-FPM. Make sure all libraries are up to date and all services have been restarted.
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
View Full Test Results (3 Failed · 348 Passed)

Event Timeline

(Build just fails because this depends on D18305.)

This revision is now accepted and ready to land.Jul 31 2017, 7:31 PM
This revision was automatically updated to reflect the committed changes.
This comment was removed by alexnb.

Neither this change nor D18305 are on stable. If you encountered an issue, you're probably mixing stable and master.

I am sorry, my phabricator was on master. Unfortunately I use git only for phabricator maintenance, resulting in such confusion.