Fixes T12930. I can't verify this fix, but the colors here work in light/dark mode correctly.
Details
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I patched down the change and restarted all services
Standard | High-Contrast | Dark Mode | Large-Font | Deuteranopia |
---|---|---|---|---|
looks good | ||||
Tried 2 different Macs and neither of them can reproduce this. It's a safe change though, feel free to accept.
I don't know - what is that? I tried on a macbook which has retina display. The other mac I tried has a monitor I think is regular type
I don't know if this matters but looks related (I never changed it, just perusing the about:config):
I'm not sure where else firefox would have details about the install. I have 3 extensions installed
- Add-on Compatibility Reporter
- Firebug
- NoScript
The other browser I was trying this on doesn't have NoScript (and I don't think has Firebug either)
Quite possibly a rabbit hole
https://bugzilla.mozilla.org/show_bug.cgi?id=910022
I also tested this change with Safari looking at Standard and High-Contrast modes - they look the same. I'm not able to test IE or FF on Windows. I could try them out tomorrow.
Not going to spend any more time here, works on my laptop, not my desktop. No real discernable difference between the two.