Page MenuHomePhabricator

Fix Firefox select dropdowns, maybe
ClosedPublic

Authored by chad on Jul 27 2017, 10:14 PM.

Details

Summary

Fixes T12930. I can't verify this fix, but the colors here work in light/dark mode correctly.

Test Plan

Wait for @cspeckmim to verify

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad created this revision.Jul 27 2017, 10:14 PM
cspeckmim edited edge metadata.Jul 27 2017, 11:49 PM

I patched down the change and restarted all services

StandardHigh-ContrastDark ModeLarge-FontDeuteranopia
looks good
chad added a comment.Jul 28 2017, 1:51 AM

what MacOS are you running?

10.12.5 "Sierra" with Firefox 54

chad added a comment.Jul 28 2017, 1:53 AM

Tried 2 different Macs and neither of them can reproduce this. It's a safe change though, feel free to accept.

chad added a comment.Jul 28 2017, 1:54 AM

Are you using HiDPI?

This revision is now accepted and ready to land.Jul 28 2017, 1:55 AM

I don't know - what is that? I tried on a macbook which has retina display. The other mac I tried has a monitor I think is regular type

I don't know if this matters but looks related (I never changed it, just perusing the about:config):

chad added a comment.Jul 28 2017, 2:00 AM

doesn't exist in my config.

I'm not sure where else firefox would have details about the install. I have 3 extensions installed

  • Add-on Compatibility Reporter
  • Firebug
  • NoScript

The other browser I was trying this on doesn't have NoScript (and I don't think has Firebug either)

By "other browser" I mean the other Mac OSX Sierra FireFox 54 (non-retina)

chad added a comment.Jul 28 2017, 2:13 AM

Ok, I have it working on my laptop but not my desktop.

Quite possibly a rabbit hole
https://bugzilla.mozilla.org/show_bug.cgi?id=910022

I also tested this change with Safari looking at Standard and High-Contrast modes - they look the same. I'm not able to test IE or FF on Windows. I could try them out tomorrow.

chad added a comment.Jul 28 2017, 2:24 AM

Not going to spend any more time here, works on my laptop, not my desktop. No real discernable difference between the two.

This revision was automatically updated to reflect the committed changes.
epriestley edited edge metadata.Jul 28 2017, 10:44 AM

(Mouse vs no mouse, to trigger scrollbars? I have a mouse...)