Properly version Legalpad documents
ClosedPublic
Actions

Authored by chad on Jul 26 2017, 2:55 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T12933: Legalpad "Updated" date is wrong

Commits

rPe7f94d7528eb: Properly version Legalpad documents

Summary

Fixes T12933. This now creates a new DocumentBody when creating or editing a legalpad document.

Test Plan

Create a new document, edit document. Check database that version is saved as new row, and timestamps are correct.

mysql> select * from legalpad_documentbody;
+----+--------------------------------+--------------------------------+--------------------------------+---------+---------------+--------+-------------+--------------+
| id | phid                           | creatorPHID                    | documentPHID                   | version | title         | text   | dateCreated | dateModified |
+----+--------------------------------+--------------------------------+--------------------------------+---------+---------------+--------+-------------+--------------+
|  1 | PHID-LEGB-nsgzqklzfmjahlcgobm7 | PHID-USER-72xwu7eurrpsu2kxgrvw | PHID-LEGD-v7mc3xyithjvbiqeksbj |       2 | Legal Title 1 | Body 2 |  1501037011 |   1501037081 |
|  2 | PHID-LEGB-2kaytwmjusljib6pjycc | PHID-USER-72xwu7eurrpsu2kxgrvw | PHID-LEGD-v7mc3xyithjvbiqeksbj |       3 | Legal Title 1 | Body 3 |  1501037521 |   1501037521 |
|  3 | PHID-LEGB-h6q6bi42w4rgxrhk3qdb | PHID-USER-72xwu7eurrpsu2kxgrvw | PHID-LEGD-7gxuhafvkoy2izkv4gdd |       1 | New 2         | asdf   |  1501037553 |   1501037553 |
+----+--------------------------------+--------------------------------+--------------------------------+---------+---------------+--------+-------------+--------------+
3 rows in set (0.00 sec)

Diff Detail

Repository

rP Phabricator

Branch

legalpad-versions (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17806
Build 23913: Run Core Tests
Build 23912: arc lint + arc unit

Event Timeline

chad created this revision.Jul 26 2017, 2:55 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJul 26 2017, 2:55 AM

chad edited the test plan for this revision. (Show Details)Jul 26 2017, 2:56 AM

Harbormaster completed remote builds in B17806: Diff 43963.Jul 26 2017, 2:56 AM

tmakarios mentioned this in T12933: Legalpad "Updated" date is wrong.Jul 26 2017, 3:34 AM

add a migration script

Harbormaster completed remote builds in B17807: Diff 43964.Jul 26 2017, 3:55 AM

tmakarios added a subscriber: tmakarios.Jul 26 2017, 4:57 AM

epriestley accepted this revision.Jul 26 2017, 2:52 PM

epriestley added inline comments.

src/applications/legalpad/editor/LegalpadDocumentEditor.php
55	Slightly more correct as `$this->getActingAsPHID()`, so we get a better PHID if an omnipotent user is acting for an application or a real user. This probably never happens on this codepath today.