Correct reporting of the last time a Legalpad document was updated
AbandonedPublic
Actions

Authored by tmakarios on Jul 20 2017, 4:30 AM.

Details

Reviewers

None

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Legalpad was always saying a document was "Updated" when it was
created, even if its body had been changed since then. This
corrects that behaviour.

Test Plan

Viewed a Legalpad document that had been siginificantly modified a
few days after its creation.

Diff Detail

Repository

rP Phabricator

Branch

legalpad-correct-last-updated

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17757
Build 23844: arc lint + arc unit

Event Timeline

tmakarios created this revision.Jul 20 2017, 4:30 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 20 2017, 4:30 AM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley removed reviewers: epriestley, Blessed Reviewers.Jul 20 2017, 3:22 PM

You're going to want to file a bug first, this isn't likely the correct fix. See Contributing Bug Reports

avivey mentioned this in T12933: Legalpad "Updated" date is wrong.Jul 24 2017, 11:34 PM

D18280 solved the underlying problem.

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

controller/

LegalpadDocumentSignController.php

2 lines

Diff 43900

View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Correct reporting of the last time a Legalpad document was updatedAbandonedPublicActions