Page MenuHomePhabricator

Add a missing read lock
Needs ReviewPublic

Authored by joshuaspence on Jul 24 2017, 11:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 8:28 PM
Unknown Object (File)
Wed, Jan 15, 7:34 PM
Unknown Object (File)
Mon, Jan 13, 4:01 PM
Unknown Object (File)
Thu, Jan 9, 10:59 PM
Unknown Object (File)
Mon, Dec 30, 2:25 AM
Unknown Object (File)
Dec 9 2024, 6:30 PM
Unknown Object (File)
Nov 25 2024, 6:04 AM
Unknown Object (File)
Nov 21 2024, 12:44 PM
Subscribers

Details

Summary

Fixes T12393. I think this is the problem?

Test Plan

After deploying this onto our Phabricator cluster, I haven't seen any "unable to update local ref" exceptions in 24 hours.

grep --no-filename --before-context=10 'cannot lock ref' /var/log/phabricator/daemons.log | grep 'EXCEPTION: (CommandException)' | awk '{print $1}' | tr --delete '[' | uniq --count
 1 2017-07-19
11 2017-07-20
 9 2017-07-21
 1 2017-07-23
 8 2017-07-24

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17783
Build 23879: Run Core Tests
Build 23878: arc lint + arc unit