Page MenuHomePhabricator

Add a missing read lock
Needs ReviewPublic

Authored by joshuaspence on Jul 24 2017, 11:00 AM.
Tags
None
Referenced Files
F19046263: D18268.diff
Nov 27 2025, 9:50 AM
F19045817: D18268.diff
Nov 27 2025, 8:39 AM
F18882719: D18268.id.diff
Nov 6 2025, 11:14 PM
F18874322: D18268.diff
Nov 5 2025, 2:07 PM
F18840558: D18268.id.diff
Oct 28 2025, 2:15 AM
F18836783: D18268.id43932.diff
Oct 27 2025, 3:37 AM
F18836782: D18268.id.diff
Oct 27 2025, 3:37 AM
F18833918: D18268.diff
Oct 26 2025, 6:43 AM
Subscribers

Details

Summary

Fixes T12393. I think this is the problem?

Test Plan

After deploying this onto our Phabricator cluster, I haven't seen any "unable to update local ref" exceptions in 24 hours.

grep --no-filename --before-context=10 'cannot lock ref' /var/log/phabricator/daemons.log | grep 'EXCEPTION: (CommandException)' | awk '{print $1}' | tr --delete '[' | uniq --count
 1 2017-07-19
11 2017-07-20
 9 2017-07-21
 1 2017-07-23
 8 2017-07-24

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17783
Build 23879: Run Core Tests
Build 23878: arc lint + arc unit