Page MenuHomePhabricator

Add a missing read lock
Needs ReviewPublic

Authored by joshuaspence on Jul 24 2017, 11:00 AM.
Tags
None
Referenced Files
F15472197: D18268.diff
Sat, Apr 5, 11:19 AM
F15468293: D18268.id.diff
Thu, Apr 3, 10:55 PM
F15464199: D18268.id43932.diff
Wed, Apr 2, 7:13 AM
F15457327: D18268.diff
Sun, Mar 30, 3:40 PM
F15413277: D18268.diff
Wed, Mar 19, 5:45 PM
F15395269: D18268.diff
Sun, Mar 16, 4:29 AM
Unknown Object (File)
Feb 21 2025, 9:08 PM
Unknown Object (File)
Feb 3 2025, 5:06 PM
Subscribers

Details

Summary

Fixes T12393. I think this is the problem?

Test Plan

After deploying this onto our Phabricator cluster, I haven't seen any "unable to update local ref" exceptions in 24 hours.

grep --no-filename --before-context=10 'cannot lock ref' /var/log/phabricator/daemons.log | grep 'EXCEPTION: (CommandException)' | awk '{print $1}' | tr --delete '[' | uniq --count
 1 2017-07-19
11 2017-07-20
 9 2017-07-21
 1 2017-07-23
 8 2017-07-24

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17783
Build 23879: Run Core Tests
Build 23878: arc lint + arc unit