Page MenuHomePhabricator

Add tabs to Diffusion for consistent navigation
ClosedPublic

Authored by chad on Jun 27 2017, 7:52 AM.
Tags
None
Referenced Files
F12837329: D18161.id43739.diff
Thu, Mar 28, 4:53 PM
Unknown Object (File)
Sun, Mar 10, 1:53 PM
Unknown Object (File)
Feb 23 2024, 2:06 PM
Unknown Object (File)
Feb 14 2024, 8:25 PM
Unknown Object (File)
Feb 3 2024, 4:17 PM
Unknown Object (File)
Jan 2 2024, 5:43 PM
Unknown Object (File)
Dec 27 2023, 11:34 AM
Unknown Object (File)
Dec 27 2023, 11:34 AM
Subscribers

Details

Summary

Adds a responsive tab bar navigation to Diffusion. Working through the new design here in pieces, so keep in mind M1477 is the target. Notably:

  • Removes "branches" and "tags" from RevisionView, now on tabs
  • Keeps "browse", "history", "readme" on RevisionView
  • Adds tabs for all main views, including Graph... unless how that feels, so let me know.
Test Plan

Browse all pages, desktop and mobile. Test hg, svn, git repositories.

Diff Detail

Repository
rP Phabricator
Branch
diffusion-tabs (branched from master)
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/aphront/configuration/AphrontApplicationConfiguration.php:274PHL1Unknown Symbol
Unit
Tests Passed
Build Status
Buildable 17621
Build 23653: Run Core Tests
Build 23652: arc lint + arc unit

Event Timeline

chad retitled this revision from [WIP] Add tabs to Diffusion for consistent navigation to Add tabs to Diffusion for consistent navigation.Jul 1 2017, 10:03 AM
chad edited the summary of this revision. (Show Details)
chad edited the test plan for this revision. (Show Details)
chad edited the summary of this revision. (Show Details)
chad planned changes to this revision.Jul 1 2017, 10:09 AM

derp, meant to test SVN

  • test more repository types
epriestley added inline comments.
src/applications/diffusion/controller/DiffusionController.php
431

$drequest->supportsBranches() is possibly a better test, but there's no equivalent for tags and this is flimsy anwyay.

This revision is now accepted and ready to land.Jul 5 2017, 7:59 PM
This revision was automatically updated to reflect the committed changes.