Paths

Table of Contentst

Differential D18161

Add tabs to Diffusion for consistent navigation
ClosedPublic
Actions

Authored by chad on Jun 27 2017, 7:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 28, 4:53 PM

	Unknown Object (File)
	Mar 10 2024, 1:53 PM

	Unknown Object (File)
	Feb 23 2024, 2:06 PM

	Unknown Object (File)
	Feb 14 2024, 8:25 PM

	Unknown Object (File)
	Feb 3 2024, 4:17 PM

	Unknown Object (File)
	Jan 2 2024, 5:43 PM

	Unknown Object (File)
	Dec 27 2023, 11:34 AM

	Unknown Object (File)
	Dec 27 2023, 11:34 AM

View All 96 Files

Subscribers

Details

Reviewers

Commits

rPe516358d54d2: Add tabs to Diffusion for consistent navigation

Summary

Adds a responsive tab bar navigation to Diffusion. Working through the new design here in pieces, so keep in mind M1477 is the target. Notably:

Removes "branches" and "tags" from RevisionView, now on tabs
Keeps "browse", "history", "readme" on RevisionView
Adds tabs for all main views, including Graph... unless how that feels, so let me know.

Test Plan

Browse all pages, desktop and mobile. Test hg, svn, git repositories.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Jun 27 2017, 7:52 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 27 2017, 7:52 AM

chad retitled this revision from [WIP] Add tabs to Diffusion for consistent navigation to Add tabs to Diffusion for consistent navigation.Jul 1 2017, 10:03 AM

chad edited the summary of this revision. (Show Details)

chad edited the test plan for this revision. (Show Details)

chad edited the summary of this revision. (Show Details)

derp, meant to test SVN

test more repository types

I guess OK to review.

chad edited the test plan for this revision. (Show Details)Jul 2 2017, 2:57 PM

epriestley accepted this revision.Jul 5 2017, 7:59 PM

epriestley added inline comments.

src/applications/diffusion/controller/DiffusionController.php
431	`$drequest->supportsBranches()` is possibly a better test, but there's no equivalent for tags and this is flimsy anwyay.

This revision is now accepted and ready to land.Jul 5 2017, 7:59 PM

Closed by commit rPe516358d54d2: Add tabs to Diffusion for consistent navigation (authored by chad, committed by chad). · Explain WhyJul 5 2017, 9:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBranchTableController.php

3 lines

DiffusionController.php

80 lines

DiffusionGraphController.php

27 lines

DiffusionHistoryController.php

29 lines

DiffusionRepositoryController.php

218 lines

DiffusionTagListController.php

3 lines

Diff 43739

src/applications/diffusion/controller/DiffusionBranchTableController.php

Loading...

src/applications/diffusion/controller/DiffusionController.php

Loading...

src/applications/diffusion/controller/DiffusionGraphController.php

Loading...

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...

src/applications/diffusion/controller/DiffusionTagListController.php

Loading...