" Config option types
ClosedPublic
Actions

Authored by epriestley on Jun 26 2017, 4:34 PM.

Details

Reviewers

chad
amckinley

Maniphest Tasks

T12845: Convert remaining ancient configuration type classes to modern modular type classes

Commits

rP467be5e53fe6: Convert the "list<string>" and "list<regex>" Config option types

Summary

Ref T12845. This updates the "list<string>" and "list<regex>" options.

Test Plan

Set, deleted, and mangled options of these types from the web UI and CLI.

Diff Detail

Repository

rP Phabricator

Branch

config3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17574
Build 23583: Run Core Tests
Build 23582: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 26 2017, 4:34 PM

Harbormaster completed remote builds in B17574: Diff 43683.Jun 26 2017, 4:35 PM

amckinley accepted this revision.Jun 26 2017, 5:05 PM

This revision is now accepted and ready to land.Jun 26 2017, 5:05 PM

Closed by commit rP467be5e53fe6: Convert the "list<string>" and "list<regex>" Config option types (authored by epriestley, committed by epriestley). · Explain WhyJun 27 2017, 7:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

config/

controller/

PhabricatorConfigEditController.php

22 lines

management/

PhabricatorConfigManagementSetWorkflow.php

25 lines

option/

PhabricatorApplicationConfigOptions.php

54 lines

type/

PhabricatorRegexListConfigType.php

24 lines

PhabricatorStringListConfigType.php

8 lines

PhabricatorTextListConfigType.php

98 lines

Diff 43683

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/controller/PhabricatorConfigEditController.php

View Options

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

View Options

src/applications/config/option/PhabricatorApplicationConfigOptions.php

View Options

src/applications/config/type/PhabricatorRegexListConfigType.php

View Options

src/applications/config/type/PhabricatorStringListConfigType.php

View Options

src/applications/config/type/PhabricatorTextListConfigType.php

Convert the "list<string>" and "list<regex>" Config option typesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43683

src/__phutil_library_map__.php

src/applications/config/controller/PhabricatorConfigEditController.php

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

src/applications/config/option/PhabricatorApplicationConfigOptions.php

src/applications/config/type/PhabricatorRegexListConfigType.php

src/applications/config/type/PhabricatorStringListConfigType.php

src/applications/config/type/PhabricatorTextListConfigType.php

Convert the "list<string>" and "list<regex>" Config option types
ClosedPublic
Actions

Revision Contents
Changeset List