Convert "enum" and "string" config options to new modular option types
ClosedPublic
Actions

Authored by epriestley on Jun 26 2017, 4:08 PM.

Details

Reviewers

chad
amckinley

Maniphest Tasks

T12845: Convert remaining ancient configuration type classes to modern modular type classes

Commits

rP9d30d49cfc73: Convert "enum" and "string" config options to new modular option types

Summary

Ref T12845. This moves the "enum" and "string" types to the new code.

Test Plan

Set, deleted, and tried to set invalid values for various enum and string config values (header color, mail prefixes, etc) from the CLI and web.

Diff Detail

Repository

rP Phabricator

Branch

config2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17573
Build 23581: Run Core Tests
Build 23580: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 26 2017, 4:08 PM

Harbormaster completed remote builds in B17573: Diff 43682.Jun 26 2017, 4:09 PM

amckinley accepted this revision.Jun 26 2017, 5:02 PM

This revision is now accepted and ready to land.Jun 26 2017, 5:02 PM

Closed by commit rP9d30d49cfc73: Convert "enum" and "string" config options to new modular option types (authored by epriestley, committed by epriestley). · Explain WhyJun 27 2017, 7:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

config/

controller/

PhabricatorConfigEditController.php

20 lines

management/

PhabricatorConfigManagementSetWorkflow.php

2 lines

option/

PhabricatorApplicationConfigOptions.php

8 lines

PhabricatorMetaMTAConfigOptions.php

6 lines

PhabricatorUIConfigOptions.php

12 lines

type/

PhabricatorEnumConfigType.php

43 lines

PhabricatorStringConfigType.php

22 lines

PhabricatorTextConfigType.php

6 lines

differential/

config/

PhabricatorDifferentialConfigOptions.php

5 lines

Diff 43682

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/controller/PhabricatorConfigEditController.php

View Options

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

View Options

src/applications/config/option/PhabricatorApplicationConfigOptions.php

View Options

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

View Options

src/applications/config/option/PhabricatorUIConfigOptions.php

View Options

src/applications/config/type/PhabricatorEnumConfigType.php

View Options

src/applications/config/type/PhabricatorStringConfigType.php

View Options

src/applications/config/type/PhabricatorTextConfigType.php

View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Convert "enum" and "string" config options to new modular option typesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43682

src/__phutil_library_map__.php

src/applications/config/controller/PhabricatorConfigEditController.php

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

src/applications/config/option/PhabricatorApplicationConfigOptions.php

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

src/applications/config/option/PhabricatorUIConfigOptions.php

src/applications/config/type/PhabricatorEnumConfigType.php

src/applications/config/type/PhabricatorStringConfigType.php

src/applications/config/type/PhabricatorTextConfigType.php

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Convert "enum" and "string" config options to new modular option types
ClosedPublic
Actions

Revision Contents
Changeset List