Page MenuHomePhabricator
Differential D18148

Add a top level tab navigation option to PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Jun 22 2017, 7:14 PM.
Tags
None
Referenced Files
F13161588: D18148.diff
Mon, May 6, 8:25 AM
Unknown Object (File)
Mon, Apr 29, 5:46 PM
Unknown Object (File)
Sat, Apr 20, 3:05 AM
Unknown Object (File)
Fri, Apr 19, 9:55 AM
Unknown Object (File)
Thu, Apr 11, 11:36 AM
Unknown Object (File)
Mar 31 2024, 12:39 PM
Unknown Object (File)
Jan 23 2024, 9:43 AM
Unknown Object (File)
Jan 15 2024, 1:06 PM
View All 69 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP58df1b7d3be2: Add a top level tab navigation option to PHUITwoColumnView
Summary

Builds out a responsive tab bar system for PHUITwoColumnView pages

Test Plan

Tested at mobile, tablet, and desktop breakpoints

Screen Shot 2017-06-22 at 9.09.21 PM.png (1×744 px, 138 KB)

Screen Shot 2017-06-22 at 9.11.23 PM.png (1×2 px, 182 KB)

Diff Detail

Repository
rP Phabricator
Branch
tabs (branched from master)
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/aphront/configuration/AphrontApplicationConfiguration.php:274PHL1Unknown Symbol
Unit
Tests Passed
Build Status
Buildable 17554
Build 23555: Run Core Tests
Build 23554: arc lint + arc unit

Event Timeline

chad created this revision.Jun 22 2017, 7:14 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJun 22 2017, 7:14 PM
chad edited the test plan for this revision. (Show Details)Jun 22 2017, 7:17 PM
epriestley accepted this revision.Jun 22 2017, 7:29 PM

That Throwable thing is fallout from T12855.

This revision is now accepted and ready to land.Jun 22 2017, 7:29 PM
Closed by commit rP58df1b7d3be2: Add a top level tab navigation option to PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyJun 22 2017, 7:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
view/
phui/
18 lines
webroot/
rsrc/
css/
phui/
71 lines
12 lines

Diff 43666

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUITwoColumnView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-list.css

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility