Paths

Table of Contentst

Make searching by tags work in Phriction
ClosedPublic
Actions

Authored by epriestley on Jun 22 2017, 5:26 PM.

Tags

None

Referenced Files

	F15518893: D18145.diff
	Sat, Apr 19, 5:51 PM

	F15490953: D18145.id43663.diff
	Fri, Apr 11, 10:02 PM

	F15479284: D18145.id43660.diff
	Tue, Apr 8, 5:50 AM

	F15469858: D18145.id.diff
	Fri, Apr 4, 5:19 PM

	F15469334: D18145.id43660.diff
	Fri, Apr 4, 12:08 PM

	F15466844: D18145.diff
	Thu, Apr 3, 10:22 AM

	F15418744: D18145.diff
	Mar 21 2025, 1:11 AM

	F15406887: D18145.id43663.diff
	Mar 18 2025, 2:31 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12860: Search by tag does not work in Phriction

Commits

rP519bec3e6f36: Make searching by tags work in Phriction

Summary

Fixes T12860. Some joins were being dropped because we didn't call parent::...

Test Plan

Tagged a document.
Searched for documents with that tag.
Before change: got all documents.
After change: got only tagged documents.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 22 2017, 5:26 PM

I think this has never worked. This line came from D14652, but I don't think it worked before that either.

interns...

This revision is now accepted and ready to land.Jun 22 2017, 5:27 PM

Harbormaster completed remote builds in B17548: Diff 43660.Jun 22 2017, 5:27 PM

Closed by commit rP519bec3e6f36: Make searching by tags work in Phriction (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2017, 6:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

query/

PhrictionDocumentQuery.php

2 lines

Diff 43663

View Options

src/applications/phriction/query/PhrictionDocumentQuery.php

Make searching by tags work in PhrictionClosedPublicActions