Page MenuHomePhabricator

Make searching by tags work in Phriction
ClosedPublic

Authored by epriestley on Jun 22 2017, 5:26 PM.
Tags
None
Referenced Files
F15390920: D18145.id43663.diff
Sat, Mar 15, 7:21 AM
Unknown Object (File)
Mon, Feb 24, 6:01 PM
Unknown Object (File)
Mon, Feb 17, 7:13 AM
Unknown Object (File)
Feb 9 2025, 4:20 AM
Unknown Object (File)
Feb 9 2025, 4:20 AM
Unknown Object (File)
Feb 9 2025, 4:20 AM
Unknown Object (File)
Jan 24 2025, 9:37 PM
Unknown Object (File)
Jan 24 2025, 9:37 PM
Subscribers
None

Details

Summary

Fixes T12860. Some joins were being dropped because we didn't call parent::...

Test Plan
  • Tagged a document.
  • Searched for documents with that tag.
  • Before change: got all documents.
  • After change: got only tagged documents.

Diff Detail

Repository
rP Phabricator
Branch
wiki1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17548
Build 23546: Run Core Tests
Build 23545: arc lint + arc unit

Event Timeline

I think this has never worked. This line came from D14652, but I don't think it worked before that either.

This revision is now accepted and ready to land.Jun 22 2017, 5:27 PM
This revision was automatically updated to reflect the committed changes.