Paths

Table of Contentst

Make searching by tags work in Phriction
ClosedPublic
Actions

Authored by epriestley on Jun 22 2017, 5:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 21, 4:06 PM

	Unknown Object (File)
	Sat, Apr 20, 5:03 AM

	Unknown Object (File)
	Sat, Apr 20, 3:30 AM

	Unknown Object (File)
	Fri, Apr 19, 6:38 PM

	Unknown Object (File)
	Wed, Apr 17, 3:06 PM

	Unknown Object (File)
	Sun, Apr 14, 11:51 AM

	Unknown Object (File)
	Wed, Apr 10, 3:28 PM

	Unknown Object (File)
	Feb 12 2024, 8:38 AM

View All 75 Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12860: Search by tag does not work in Phriction

Commits

rP519bec3e6f36: Make searching by tags work in Phriction

Summary

Fixes T12860. Some joins were being dropped because we didn't call parent::...

Test Plan

Tagged a document.
Searched for documents with that tag.
Before change: got all documents.
After change: got only tagged documents.

Diff Detail

Repository

rP Phabricator

Branch

wiki1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17548
Build 23546: Run Core Tests
Build 23545: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 22 2017, 5:26 PM

I think this has never worked. This line came from D14652, but I don't think it worked before that either.

interns...

This revision is now accepted and ready to land.Jun 22 2017, 5:27 PM

Harbormaster completed remote builds in B17548: Diff 43660.Jun 22 2017, 5:27 PM

Closed by commit rP519bec3e6f36: Make searching by tags work in Phriction (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2017, 6:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

query/

PhrictionDocumentQuery.php

2 lines

Diff 43660

View Options

src/applications/phriction/query/PhrictionDocumentQuery.php

Make searching by tags work in PhrictionClosedPublicActions