Add options for hidding inlines to the Differential header banner
ClosedPublic
Actions

Authored by epriestley on Jun 15 2017, 12:03 PM.

Details

Reviewers

chad

Maniphest Tasks

T8909: Provide ability to hide all inline or done comments
T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rPb3b30dde6ac9: Add options for hidding inlines to the Differential header banner

Summary

Fixes T8909. Ref T12733.

UI attempts to follow the mock, but is a bit rough since PHUIXButtonView without text in this menu gets weird spacing, we don't have circular buttons yet, and PHUIXActionView without an icon also gets odd spacing.

Test Plan

Screen Shot 2017-06-15 at 5.01.51 AM.png (1×1 px, 232 KB)

Diff Detail

Repository

rP Phabricator

Branch

menu3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17511
Build 23487: Run Core Tests
Build 23486: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 15 2017, 12:03 PM

Harbormaster completed remote builds in B17511: Diff 43619.Jun 15 2017, 12:04 PM

I wonder if we should put the view all inlines link here instead of actions

Hmm, maybe a little surprising that it takes you to a separate document and you lose your place? But I can move it if you want.

Maybe use the external link icon and put a divider above it. I'd slightly prefer it in this menu instead of the action menu, not sold on either though

This revision is now accepted and ready to land.Jun 15 2017, 12:13 PM