Differential D18127

Consider inline comments with draft checkmarks as "unsubmitted"
ClosedPublic
Actions

Authored by epriestley on Jun 15 2017, 11:31 AM.

Tags

None

Referenced Files

	F20380822: D18127.diff
	Sat, Jun 13, 1:24 AM

	Unknown Object (File)
	Apr 15 2026, 9:18 PM

	Unknown Object (File)
	Mar 5 2026, 5:41 AM

	Unknown Object (File)
	Feb 11 2026, 1:29 PM

	Unknown Object (File)
	Oct 13 2025, 5:07 AM

	Unknown Object (File)
	Oct 6 2025, 7:17 AM

	Unknown Object (File)
	Sep 15 2025, 12:30 AM

	Unknown Object (File)
	Sep 13 2025, 11:15 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rP3be36783b377: Consider inline comments with draft checkmarks as "unsubmitted"

Summary

Ref T12733. When a revision has unsubmitted checkmarks:

Color the banner yellow.
Show them in the "X unsubmitted" count.
Make the "X unsubmitted" button cycle between all drafts (written but unpublished comments) and "draft done" (checked but unsubmitted "Done" checkbox comments).

Test Plan

Checked a "Done" box, saw "1 unsubmitted" and yellow banner.
Clicked "5 unsubmitted" repeatedly, saw it cycle through all unsubmitted comments and checkboxes.

Diff Detail

Repository

Branch

menu2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17510
Build 23485: Run Core Tests
Build 23484: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 15 2017, 11:31 AM

Harbormaster completed remote builds in B17510: Diff 43618.Jun 15 2017, 11:32 AM

chad accepted this revision.Jun 15 2017, 12:18 PM

This revision is now accepted and ready to land.Jun 15 2017, 12:18 PM

Closed by commit rP3be36783b377: Consider inline comments with draft checkmarks as "unsubmitted" (authored by epriestley, committed by epriestley). · Explain WhyJun 15 2017, 12:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

62 lines

src/

infrastructure/

diff/

view/

PHUIDiffInlineCommentDetailView.php

9 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

3 lines

js/

application/

diff/

DiffChangeset.js

2 lines

DiffChangesetList.js

29 lines

7 lines

Diff 43618

resources/celerity/map.php

Loading...

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...

webroot/rsrc/css/application/differential/changeset-view.css

Loading...

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...

webroot/rsrc/js/application/diff/DiffInline.js

Loading...