Add a tooltip method to PHUIIconView
ClosedPublic
Actions

Authored by chad on Jun 10 2017, 11:17 PM.

Tags

None

Referenced Files

	F13145737: D18114.diff
	Fri, May 3, 9:17 AM

	Unknown Object (File)
	Thu, Apr 25, 2:54 AM

	Unknown Object (File)
	Wed, Apr 24, 1:19 PM

	Unknown Object (File)
	Thu, Apr 11, 10:24 AM

	Unknown Object (File)
	Sun, Apr 7, 3:31 AM

	Unknown Object (File)
	Sun, Apr 7, 2:02 AM

	Unknown Object (File)
	Sun, Apr 7, 1:48 AM

	Unknown Object (File)
	Sun, Apr 7, 12:34 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP2a3022913f06: Add a tooltip method to PHUIIconView

Summary

We seem to use these a lot. Makes the code cleaner.

Test Plan

UIExamples.

Diff Detail

Repository

rP Phabricator

Branch

icon-tooltip (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17473
Build 23428: Run Core Tests
Build 23427: arc lint + arc unit

Event Timeline

chad created this revision.Jun 10 2017, 11:17 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 10 2017, 11:17 PM

Harbormaster completed remote builds in B17473: Diff 43575.Jun 10 2017, 11:17 PM

Harbormaster completed remote builds in B17473: Diff 43575.

epriestley accepted this revision.Jun 12 2017, 4:53 PM

This revision is now accepted and ready to land.Jun 12 2017, 4:53 PM

Closed by commit rP2a3022913f06: Add a tooltip method to PHUIIconView (authored by chad, committed by chad). · Explain WhyJun 12 2017, 6:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

uiexample/

examples/

PHUIIconExample.php

3 lines

view/

phui/

PHUIIconView.php

19 lines

Diff 43575

View Options

src/applications/uiexample/examples/PHUIIconExample.php