Paths

Table of Contentst

Send permanent dameon failures to the log, even when not running in verbose mode
ClosedPublic
Actions

Authored by epriestley on Jun 8 2017, 1:21 PM.

Details

Reviewers

chad
amckinley

Maniphest Tasks

T12803: When tasks fail permanently, they should log the failure even if `phd.verbose` is not enabled

Commits

rP3400f24c8b53: Send permanent dameon failures to the log, even when not running in verbose mode

Summary

Fixes T12803. An install is having difficulty diagnosing mail failures, and one component is that permanent task failures aren't reaching the log.

It's reasonable to send these to the log even when "phd.verbose" is off. See T12803 for a rough review of when we generate these failrues today.

Test Plan

Faked some exceptions.
Got a result in the log (P2058) with phd.verbose turned off.

Diff Detail

Repository

rP Phabricator

Branch

daemon1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17450
Build 23394: Run Core Tests
Build 23393: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 8 2017, 1:21 PM

Harbormaster completed remote builds in B17450: Diff 43553.Jun 8 2017, 1:22 PM

chad accepted this revision.Jun 8 2017, 10:05 PM

This revision is now accepted and ready to land.Jun 8 2017, 10:05 PM

Closed by commit rP3400f24c8b53: Send permanent dameon failures to the log, even when not running in verbose mode (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2017, 10:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

PhabricatorMetaMTAWorker.php

17 lines

infrastructure/

daemon/

workers/

PhabricatorTaskmasterDaemon.php

12 lines

Diff 43553

View Options

src/applications/metamta/PhabricatorMetaMTAWorker.php