Page MenuHomePhabricator
Differential D18103

Fix minor inline comment header button behaviors
ClosedPublic
Actions

Authored by epriestley on Jun 8 2017, 2:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 4:24 AM
Unknown Object (File)
Thu, Nov 21, 4:24 AM
Unknown Object (File)
Thu, Nov 21, 4:24 AM
Unknown Object (File)
Thu, Nov 21, 3:57 AM
Unknown Object (File)
Mon, Nov 11, 6:03 AM
Unknown Object (File)
Sun, Nov 3, 6:19 AM
Unknown Object (File)
Sat, Nov 2, 12:33 AM
Unknown Object (File)
Oct 23 2024, 3:05 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
T12806: In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments
Commits
rP8692d673c8ab: Fix minor inline comment header button behaviors
Summary

Fixes T12806. Ref T12733.

  • Don't count synthetic (lint) comments as anything.
  • When you begin writing an inline then cancel it, don't count it as anything.
  • When we would show "0 / X", just show "X".
Test Plan
  • Viewed a diff with synthetic comments, no button.
  • Wrote, then cancelled an inline. No "X comments".
  • Clicked / unlicked "Done", saw "X" -> "1 / X".

Diff Detail

Repository
rP Phabricator
Branch
inline1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17445
Build 23386: Run Core Tests
Build 23385: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 8 2017, 2:06 AM
Harbormaster completed remote builds in B17445: Diff 43549.Jun 8 2017, 2:07 AM
chad accepted this revision.Jun 8 2017, 2:09 AM
This revision is now accepted and ready to land.Jun 8 2017, 2:09 AM
Closed by commit rP8692d673c8ab: Fix minor inline comment header button behaviors (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2017, 2:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
infrastructure/
diff/
view/
11 lines
webroot/
rsrc/
js/
application/
diff/
37 lines
6 lines

Diff 43549

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility