Page MenuHomePhabricator
Differential D18051

Add PHUIXButtonView and a UIExample
ClosedPublic
Actions

Authored by epriestley on May 31 2017, 12:10 AM.
Tags
None
Referenced Files
F15379208: D18051.id43412.diff
Thu, Mar 13, 7:25 PM
Unknown Object (File)
Sun, Feb 16, 2:27 AM
Unknown Object (File)
Feb 12 2025, 11:03 PM
Unknown Object (File)
Jan 27 2025, 11:22 PM
Unknown Object (File)
Jan 21 2025, 12:46 PM
Unknown Object (File)
Jan 17 2025, 7:08 AM
Unknown Object (File)
Jan 13 2025, 8:47 AM
Unknown Object (File)
Dec 16 2024, 1:47 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP683647f1fb90: Add PHUIXButtonView and a UIExample
Summary

Ref T12733. Ref M1476. This adds PHUIXButtonView, for client-side button rendering.

It also adds a PHUIX example which renders the server and client versions of each component side-by-side so it's easier to see if they're messed up.

Test Plan

Screen Shot 2017-05-30 at 5.05.33 PM.png (1×1 px, 146 KB)

Diff Detail

Repository
rP Phabricator
Branch
head7
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/phuix/PHUIXButtonView.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 17325
Build 23220: Run Core Tests
Build 23219: arc lint + arc unit

Event Timeline

epriestley created this revision.May 31 2017, 12:10 AM
chad accepted this revision.May 31 2017, 12:29 AM

tumblr_inline_op017kGTqT1teupc5_540.gif (345×498 px, 2 MB)

This revision is now accepted and ready to land.May 31 2017, 12:29 AM
Closed by commit rP683647f1fb90: Add PHUIXButtonView and a UIExample (authored by epriestley, committed by epriestley). · Explain WhyMay 31 2017, 1:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
13 lines
src/
2 lines
applications/
uiexample/
examples/
122 lines
webroot/
rsrc/
js/
phuix/
109 lines
65 lines

Diff 43412

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/uiexample/examples/PHUIXComponentsExample.php

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXButtonView.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXExample.js

Loading...
Phabricator · Built by Phacility