Paths

Table of Contentst

Differential D18051

Add PHUIXButtonView and a UIExample
ClosedPublic
Actions

Authored by epriestley on May 31 2017, 12:10 AM.

Details

Reviewers

chad

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rP683647f1fb90: Add PHUIXButtonView and a UIExample

Summary

Ref T12733. Ref M1476. This adds PHUIXButtonView, for client-side button rendering.

It also adds a PHUIX example which renders the server and client versions of each component side-by-side so it's easier to see if they're messed up.

Test Plan

Screen Shot 2017-05-30 at 5.05.33 PM.png (1×1 px, 146 KB)

Diff Detail

Repository

rP Phabricator

Branch

head7

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/phuix/PHUIXButtonView.js:1	JAVELIN5	`javelinsymbols` Not In Path

Unit

Tests Passed

Build Status

Buildable 17325
Build 23220: Run Core Tests
Build 23219: arc lint + arc unit

Event Timeline

epriestley created this revision.May 31 2017, 12:10 AM

tumblr_inline_op017kGTqT1teupc5_540.gif (345×498 px, 2 MB)

This revision is now accepted and ready to land.May 31 2017, 12:29 AM

Closed by commit rP683647f1fb90: Add PHUIXButtonView and a UIExample (authored by epriestley, committed by epriestley). · Explain WhyMay 31 2017, 1:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

13 lines

src/

__phutil_library_map__.php

2 lines

applications/

uiexample/

examples/

PHUIXComponentsExample.php

122 lines

webroot/

rsrc/

js/

phuix/

PHUIXButtonView.js

109 lines

PHUIXExample.js

65 lines

Diff 43412

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/uiexample/examples/PHUIXComponentsExample.php

View Options

webroot/rsrc/js/phuix/PHUIXButtonView.js

View Options

webroot/rsrc/js/phuix/PHUIXExample.js

Add PHUIXButtonView and a UIExampleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43412

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/uiexample/examples/PHUIXComponentsExample.php

webroot/rsrc/js/phuix/PHUIXButtonView.js

webroot/rsrc/js/phuix/PHUIXExample.js

Add PHUIXButtonView and a UIExample
ClosedPublic
Actions

Revision Contents
Changeset List