Page MenuHomePhabricator

Group query results under the "ANCESTOR" operator unconditionally
ClosedPublic

Authored by epriestley on May 24 2017, 6:51 PM.
Tags
None
Referenced Files
F19941189: D18012.diff
Wed, Apr 15, 8:49 AM
F19820956: D18012.id43330.diff
Mar 6 2026, 5:38 PM
F19561826: D18012.id43330.diff
Jan 31 2026, 11:55 AM
F18909445: D18012.diff
Nov 9 2025, 2:11 AM
F18798950: D18012.id43330.diff
Oct 17 2025, 10:13 AM
F18772198: D18012.id43330.diff
Oct 9 2025, 1:01 AM
F18733616: D18012.id.diff
Sep 30 2025, 10:38 PM
F18720134: D18012.id.diff
Sep 29 2025, 6:30 PM
Subscribers
None

Details

Summary

Fixes T12753. See that task for reproduction instructions.

We add a GROUP BY clause to queries with an "ANCESTOR" edge constraint only if the constaint has more than one PHID, but this is incorrect: the same row can be found twice by an ANCESTOR query if task T is tagged with both "B" and "C", children of "A", and the user queries for "tasks in A".

Instead, always add GROUP BY for ANCESTOR queries.

Test Plan
  • Followed test plan in T12753.
  • Saw proper paging controls after change.
  • Saw GROUP BY in DarkConsole.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable