Page MenuHomePhabricator

Group query results under the "ANCESTOR" operator unconditionally
ClosedPublic

Authored by epriestley on May 24 2017, 6:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 8:06 PM
Unknown Object (File)
Sun, Nov 10, 3:31 PM
Unknown Object (File)
Sat, Nov 9, 1:51 PM
Unknown Object (File)
Wed, Nov 6, 11:57 AM
Unknown Object (File)
Oct 27 2024, 3:01 AM
Unknown Object (File)
Oct 22 2024, 3:02 AM
Unknown Object (File)
Oct 21 2024, 11:40 PM
Unknown Object (File)
Oct 15 2024, 7:33 AM
Subscribers
None

Details

Summary

Fixes T12753. See that task for reproduction instructions.

We add a GROUP BY clause to queries with an "ANCESTOR" edge constraint only if the constaint has more than one PHID, but this is incorrect: the same row can be found twice by an ANCESTOR query if task T is tagged with both "B" and "C", children of "A", and the user queries for "tasks in A".

Instead, always add GROUP BY for ANCESTOR queries.

Test Plan
  • Followed test plan in T12753.
  • Saw proper paging controls after change.
  • Saw GROUP BY in DarkConsole.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable