Page MenuHomePhabricator

Group query results under the "ANCESTOR" operator unconditionally
ClosedPublic

Authored by epriestley on May 24 2017, 6:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 24 2024, 10:26 AM
Unknown Object (File)
Feb 8 2024, 6:02 PM
Unknown Object (File)
Feb 7 2024, 6:41 PM
Unknown Object (File)
Jan 25 2024, 12:09 AM
Unknown Object (File)
Jan 8 2024, 2:49 AM
Unknown Object (File)
Jan 7 2024, 10:39 AM
Unknown Object (File)
Dec 27 2023, 10:24 PM
Unknown Object (File)
Dec 27 2023, 11:14 AM
Subscribers
None

Details

Summary

Fixes T12753. See that task for reproduction instructions.

We add a GROUP BY clause to queries with an "ANCESTOR" edge constraint only if the constaint has more than one PHID, but this is incorrect: the same row can be found twice by an ANCESTOR query if task T is tagged with both "B" and "C", children of "A", and the user queries for "tasks in A".

Instead, always add GROUP BY for ANCESTOR queries.

Test Plan
  • Followed test plan in T12753.
  • Saw proper paging controls after change.
  • Saw GROUP BY in DarkConsole.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable