Page MenuHomePhabricator

Add a dedicated HistoryListView for Diffusion
ClosedPublic

Authored by chad on May 23 2017, 8:48 PM.
Tags
None
Referenced Files
F15332596: D18005.id43305.diff
Fri, Mar 7, 6:27 PM
Unknown Object (File)
Feb 1 2025, 4:08 AM
Unknown Object (File)
Jan 29 2025, 10:22 AM
Unknown Object (File)
Jan 22 2025, 7:35 AM
Unknown Object (File)
Jan 20 2025, 6:46 AM
Unknown Object (File)
Jan 18 2025, 11:06 PM
Unknown Object (File)
Jan 2 2025, 10:24 PM
Unknown Object (File)
Dec 16 2024, 5:48 PM
Subscribers

Details

Summary

Going to play a bit with this layout (diffusion sans audit) and see how it feels on profile. Uses a user image, moves the commit hash (easily selectible) and separates commits by date.

Test Plan

Review profiles with and without commits.

image.png (2×2 px, 482 KB)

Diff Detail

Repository
rP Phabricator
Branch
history-list-view (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17218
Build 23049: Run Core Tests
Build 23048: arc lint + arc unit

Event Timeline

Feels a lot like "copy GitHub" to me, but I think everyone loves GitHub's UI and hates Diffusion's UI so that's probably not a bad thing.

This revision is now accepted and ready to land.May 23 2017, 8:55 PM
src/applications/diffusion/view/DiffusionHistoryListView.php
48

Likely pre-existing, but "impoting".

92

This isn't translatable/UTF8-safe but whatevs, we can cross that bridge when we come to it.

136

Or just $cur_date = $new_date;

141–142

Extra indentation?

This revision was automatically updated to reflect the committed changes.