Add a dedicated HistoryListView for Diffusion
ClosedPublic
Actions

Authored by chad on May 23 2017, 8:48 PM.

Details

Reviewers

epriestley

Commits

rP1b36252ef39b: Add a dedicated HistoryListView for Diffusion

Summary

Going to play a bit with this layout (diffusion sans audit) and see how it feels on profile. Uses a user image, moves the commit hash (easily selectible) and separates commits by date.

Test Plan

Review profiles with and without commits.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 23 2017, 8:48 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 23 2017, 8:48 PM

Harbormaster completed remote builds in B17216: Diff 43304.May 23 2017, 8:49 PM

chad edited the test plan for this revision. (Show Details)May 23 2017, 8:50 PM

not needed

Harbormaster completed remote builds in B17217: Diff 43305.May 23 2017, 8:54 PM

Feels a lot like "copy GitHub" to me, but I think everyone loves GitHub's UI and hates Diffusion's UI so that's probably not a bad thing.

This revision is now accepted and ready to land.May 23 2017, 8:55 PM

epriestley added inline comments.May 23 2017, 8:57 PM

src/applications/diffusion/view/DiffusionHistoryListView.php
48	Likely pre-existing, but "impoting".
92	This isn't translatable/UTF8-safe but whatevs, we can cross that bridge when we come to it.
136	Or just `$cur_date = $new_date;`
141–142	Extra indentation?